Issue 88080043: state: chattier EnsureAvailability

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 88080043: state: chattier EnsureAvailability

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years ago by rog

Modified:
10 years ago

Reviewers:
axw, mp+215832, natefinch

Visibility:
Public.

Description

state: chattier EnsureAvailability We want to find out why it makes the decisions it does. To make the log messages nicer, this needed a little bit of refactoring, which should also make it easier for the future work to report EnsureAvailability actions back to the user. It arguably makes the code easier to understand too, as concerns are separated slightly better. https://code.launchpad.net/~rogpeppe/juju-core/549-ensure-availability-chatty/+merge/215832 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : state: chattier EnsureAvailability #

Total comments: 2

Patch Set 3 : state: chattier EnsureAvailability #

Created: 10 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+86 lines, -49 lines)			Patch
	A	[revision details]	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
	M	state/addmachine.go	View	1 2	3 chunks	+84 lines, -49 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

axw

LGTM https://codereview.appspot.com/88080043/diff/20001/state/addmachine.go File state/addmachine.go (right): https://codereview.appspot.com/88080043/diff/20001/state/addmachine.go#newcode561 state/addmachine.go:561: // First the operations to remove state-server status. ...

10 years ago (2014-04-15 10:15:24 UTC) #3

rog

10 years ago (2014-04-15 10:34:21 UTC) #4

Please take a look.

https://codereview.appspot.com/88080043/diff/20001/state/addmachine.go
File state/addmachine.go (right):

https://codereview.appspot.com/88080043/diff/20001/state/addmachine.go#newcod...
state/addmachine.go:561: // First the operations to remove state-server status.
On 2014/04/15 10:15:25, axw wrote:
> This comment is not quite right. add/remove?
> I don't really think it adds much, TBH.

yes, it's a relic. removed.

Expand All Messages | Collapse All Messages