Hello agl@golang.org (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://hanwen%40google.com@code.google.com/p/go.crypto/
12 years, 6 months ago
(2014-04-15 09:04:31 UTC)
#1
On 2014/04/15 09:04:31, hanwen-google wrote: > Hello mailto:agl@golang.org (cc: mailto:golang-codereviews@googlegroups.com), > > I'd like you ...
12 years, 6 months ago
(2014-04-15 10:17:41 UTC)
#2
On 2014/04/15 09:04:31, hanwen-google wrote:
> Hello mailto:agl@golang.org (cc: mailto:golang-codereviews@googlegroups.com),
>
> I'd like you to review this change to
> https://hanwen%40google.com@code.google.com/p/go.crypto/
LGTM. Is the RNG being seeded ?
On 2014/04/15 10:17:41, dfc wrote: > On 2014/04/15 09:04:31, hanwen-google wrote: > > Hello mailto:agl@golang.org ...
12 years, 6 months ago
(2014-04-15 10:24:44 UTC)
#3
On 2014/04/15 10:17:41, dfc wrote:
> On 2014/04/15 09:04:31, hanwen-google wrote:
> > Hello mailto:agl@golang.org (cc:
mailto:golang-codereviews@googlegroups.com),
> >
> > I'd like you to review this change to
> > https://hanwen%40google.com@code.google.com/p/go.crypto/
>
> LGTM. Is the RNG being seeded ?
I guess not.
Could be worse, 1 is a valid seed. On Tue, Apr 15, 2014 at 8:24 ...
12 years, 6 months ago
(2014-04-15 10:36:15 UTC)
#4
Could be worse, 1 is a valid seed.
On Tue, Apr 15, 2014 at 8:24 PM, <hanwen@google.com> wrote:
> On 2014/04/15 10:17:41, dfc wrote:
>>
>> On 2014/04/15 09:04:31, hanwen-google wrote:
>> > Hello mailto:agl@golang.org (cc:
>
> mailto:golang-codereviews@googlegroups.com),
>>
>> >
>> > I'd like you to review this change to
>> > https://hanwen%40google.com@code.google.com/p/go.crypto/
>
>
>> LGTM. Is the RNG being seeded ?
>
>
> I guess not.
>
> https://codereview.appspot.com/88060043/
Issue 88060043: code review 88060043: go.crypto/ssh: fix messages_test.go on 32-bit platforms.
(Closed)
Created 12 years, 6 months ago by hanwen-google
Modified 12 years, 6 months ago
Reviewers:
Base URL:
Comments: 0