Issue 8804046: Adjust the browser to not overlay whole screen.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 8804046: Adjust the browser to not overlay whole screen.

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 5 months ago by rharding

Modified:
11 years, 5 months ago

Reviewers:
j.c.sackett, mp+159626

Visibility:
Public.

Description

Adjust the browser to not overlay whole screen. - Formalize how the div for the browser is toggled. - Adjust CSS so that in /bws/sidebar you can access the environment next to it. https://code.launchpad.net/~rharding/juju-gui/fix-overlayed-browser-div/+merge/159626 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Adjust the browser to not overlay whole screen. #

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+43 lines, -7 lines)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	app/subapps/browser/browser.js	View	3 chunks	+25 lines, -5 lines	0 comments	Download
M	lib/views/browser/main.less	View	4 chunks	+16 lines, -2 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

rharding

LGTM but added a card because the sidebar can't really show well on browser widths ...

11 years, 5 months ago (2013-04-18 15:40:33 UTC) #2

rharding

11 years, 5 months ago (2013-04-18 16:06:16 UTC) #4

*** Submitted:

Adjust the browser to not overlay whole screen.

- Formalize how the div for the browser is toggled.
- Adjust CSS so that in /bws/sidebar you can access the environment next to
it.

R=j.c.sackett
CC=
https://codereview.appspot.com/8804046

Expand All Messages | Collapse All Messages