Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(300)

Issue 8799047: code review 8799047: time: improve the explanation of the working of Format ... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years ago by r
Modified:
12 years ago
Reviewers:
knieriem
CC:
golang-dev, bradfitz
Visibility:
Public.

Description

time: improve the explanation of the working of Format and Parse Change the term 'standard time', which already means something, to 'reference time', and add a couple of sentences and clarifications.

Patch Set 1 #

Total comments: 2

Patch Set 2 : diff -r be96dbedf109 https://code.google.com/p/go #

Patch Set 3 : diff -r be96dbedf109 https://code.google.com/p/go #

Patch Set 4 : diff -r be96dbedf109 https://code.google.com/p/go #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -20 lines) Patch
M src/pkg/time/example_test.go View 1 2 1 chunk +8 lines, -3 lines 0 comments Download
M src/pkg/time/format.go View 3 chunks +24 lines, -17 lines 1 comment Download

Messages

Total messages: 7
r
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go
12 years ago (2013-04-22 17:29:39 UTC) #1
bradfitz
https://codereview.appspot.com/8799047/diff/1/src/pkg/time/example_test.go File src/pkg/time/example_test.go (right): https://codereview.appspot.com/8799047/diff/1/src/pkg/time/example_test.go#newcode62 src/pkg/time/example_test.go:62: const format = "Jan 2, 2006 at 3:04pm (MST)" ...
12 years ago (2013-04-22 17:37:08 UTC) #2
r
https://codereview.appspot.com/8799047/diff/1/src/pkg/time/example_test.go File src/pkg/time/example_test.go (right): https://codereview.appspot.com/8799047/diff/1/src/pkg/time/example_test.go#newcode62 src/pkg/time/example_test.go:62: const format = "Jan 2, 2006 at 3:04pm (MST)" ...
12 years ago (2013-04-22 17:56:44 UTC) #3
r
Hello golang-dev@googlegroups.com, bradfitz@golang.org (cc: golang-dev@googlegroups.com), Please take another look.
12 years ago (2013-04-22 17:58:11 UTC) #4
bradfitz
LGTM
12 years ago (2013-04-22 18:27:33 UTC) #5
r
*** Submitted as https://code.google.com/p/go/source/detail?r=60242cfc12c3 *** time: improve the explanation of the working of Format and ...
12 years ago (2013-04-22 18:36:24 UTC) #6
knieriem
12 years ago (2013-04-22 19:11:59 UTC) #7
Message was sent while issue was closed.
https://codereview.appspot.com/8799047/diff/10001/src/pkg/time/format.go
File src/pkg/time/format.go (right):

https://codereview.appspot.com/8799047/diff/10001/src/pkg/time/format.go#newc...
src/pkg/time/format.go:637: // would be interepreted if it were the value; it
serves as an example of
One letter 'e' too many?
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b