Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2819)

Issue 8799045: Gives DynamicTextSpanner a default skyline-horizontal-padding

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years ago by MikeSol
Modified:
11 years ago
Reviewers:
Keith, janek, lemzwerg, mike7
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Gives DynamicTextSpanner a default skyline-horizontal-padding

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M scm/define-grobs.scm View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5
lemzwerg
LGTM.
11 years ago (2013-04-17 08:45:42 UTC) #1
janek
LGTM
11 years ago (2013-04-17 20:40:12 UTC) #2
Keith
I suggest that you set the defaults consistently for all text grobs, so that I ...
11 years ago (2013-04-18 07:51:14 UTC) #3
mike7
On 18 avr. 2013, at 10:51, k-ohara5a5a@oco.net wrote: > I suggest that you set the ...
11 years ago (2013-04-18 08:53:04 UTC) #4
mike7
11 years ago (2013-04-18 08:53:34 UTC) #5
On 18 avr. 2013, at 10:51, k-ohara5a5a@oco.net wrote:

> I suggest that you set the defaults consistently for all text grobs, so
> that I don't have to file bug reports one-at-a-time for every possible
> case:
> 
> \paper { indent = 0\mm
> line-width = 42.2\mm
> ragged-right = ##f }
> \score { << \new Staff { b1_\markup\huge"innocent" }
>    \new Staff << { e''4 e''' r2 } \\ e'1 >> >> }
> 

They're different beasts - we need to figure out what is the best value for each
one given its habitual size and content. Bigger grobs should get bigger default
values. I'd like to raise separate issues for different families. For example,
text spanner and dynamic next spanner make sense together in the same patch with
the same default vale, but not text script and metronome mark.

Cheers,
MS

> https://codereview.appspot.com/8799045/
> 
> _______________________________________________
> lilypond-devel mailing list
> lilypond-devel@gnu.org
> https://lists.gnu.org/mailman/listinfo/lilypond-devel
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b