Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(5849)

Issue 8797048: CPP: Move base/ to phonenumbers/. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 12 months ago by pliard1
Modified:
10 years, 12 months ago
Reviewers:
Shaopeng
CC:
lararennie
Base URL:
https://libphonenumber.googlecode.com/svn/trunk
Visibility:
Public.

Description

CPP: Move base/ to phonenumbers/. This will be needed to make libphonenumber depend on its own base/ rather than Chromium's one as it is the case currently. BUG=http://crbug.com/236272 R=jia.shao.peng@gmail.com Committed: https://code.google.com/p/libphonenumber/source/detail?r=567

Patch Set 1 #

Patch Set 2 : Update missing reference to basictypes.h in geodata generator #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -923 lines) Patch
M cpp/CMakeLists.txt View 2 chunks +10 lines, -7 lines 0 comments Download
D cpp/src/base/basictypes.h View 1 chunk +0 lines, -302 lines 0 comments Download
D cpp/src/base/logging.h View 1 chunk +0 lines, -37 lines 0 comments Download
D cpp/src/base/memory/scoped_ptr.h View 1 chunk +0 lines, -24 lines 0 comments Download
D cpp/src/base/memory/singleton.h View 1 chunk +0 lines, -52 lines 0 comments Download
D cpp/src/base/strings/string_piece.h View 1 chunk +0 lines, -192 lines 0 comments Download
D cpp/src/base/strings/string_piece.cc View 1 chunk +0 lines, -219 lines 0 comments Download
D cpp/src/base/synchronization/lock.h View 1 chunk +0 lines, -27 lines 0 comments Download
M cpp/src/phonenumbers/asyoutypeformatter.h View 1 chunk +2 lines, -2 lines 0 comments Download
M cpp/src/phonenumbers/asyoutypeformatter.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + cpp/src/phonenumbers/base/basictypes.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + cpp/src/phonenumbers/base/logging.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + cpp/src/phonenumbers/base/memory/scoped_ptr.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + cpp/src/phonenumbers/base/memory/singleton.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + cpp/src/phonenumbers/base/strings/string_piece.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + cpp/src/phonenumbers/base/strings/string_piece.cc View 1 chunk +1 line, -1 line 0 comments Download
A + cpp/src/phonenumbers/base/synchronization/lock.h View 0 chunks +-1 lines, --1 lines 0 comments Download
M cpp/src/phonenumbers/encoding_utils.h View 1 chunk +1 line, -1 line 0 comments Download
M cpp/src/phonenumbers/geocoding/area_code_map.h View 1 chunk +2 lines, -2 lines 0 comments Download
M cpp/src/phonenumbers/geocoding/default_map_storage.h View 1 chunk +1 line, -1 line 0 comments Download
M cpp/src/phonenumbers/geocoding/default_map_storage.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M cpp/src/phonenumbers/geocoding/geocoding_data.h View 1 chunk +1 line, -1 line 0 comments Download
M cpp/src/phonenumbers/geocoding/mapping_file_provider.h View 1 chunk +1 line, -1 line 0 comments Download
M cpp/src/phonenumbers/geocoding/phonenumber_offline_geocoder.h View 1 chunk +2 lines, -2 lines 0 comments Download
M cpp/src/phonenumbers/phonenumbermatch.h View 1 chunk +1 line, -1 line 0 comments Download
M cpp/src/phonenumbers/phonenumbermatcher.h View 1 chunk +2 lines, -2 lines 0 comments Download
M cpp/src/phonenumbers/phonenumbermatcher.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M cpp/src/phonenumbers/phonenumberutil.h View 1 chunk +3 lines, -3 lines 0 comments Download
M cpp/src/phonenumbers/phonenumberutil.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M cpp/src/phonenumbers/regexp_adapter_icu.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M cpp/src/phonenumbers/regexp_adapter_re2.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M cpp/src/phonenumbers/regexp_cache.h View 1 chunk +3 lines, -3 lines 0 comments Download
M cpp/src/phonenumbers/regexp_cache.cc View 1 chunk +1 line, -1 line 0 comments Download
M cpp/src/phonenumbers/shortnumberutil.h View 1 chunk +1 line, -1 line 0 comments Download
M cpp/src/phonenumbers/shortnumberutil.cc View 1 chunk +1 line, -1 line 0 comments Download
M cpp/src/phonenumbers/stringutil.h View 1 chunk +1 line, -1 line 0 comments Download
M cpp/src/phonenumbers/utf/stringpiece.h View 1 chunk +1 line, -1 line 0 comments Download
M cpp/src/phonenumbers/utf/stringprintf.h View 1 chunk +1 line, -1 line 0 comments Download
M cpp/src/phonenumbers/utf/unicodetext.h View 1 chunk +1 line, -1 line 0 comments Download
M cpp/src/phonenumbers/utf/unicodetext.cc View 1 chunk +1 line, -1 line 0 comments Download
M cpp/src/phonenumbers/utf/unilib.h View 1 chunk +1 line, -1 line 0 comments Download
M cpp/src/phonenumbers/utf/unilib.cc View 1 chunk +1 line, -1 line 0 comments Download
M cpp/test/phonenumbers/asyoutypeformatter_test.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M cpp/test/phonenumbers/geocoding/geocoding_data_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M cpp/test/phonenumbers/geocoding/geocoding_test_data.h View 1 chunk +1 line, -1 line 0 comments Download
M cpp/test/phonenumbers/logger_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M cpp/test/phonenumbers/phonenumbermatcher_test.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M cpp/test/phonenumbers/regexp_adapter_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M tools/cpp/src/cpp-build/generate_geocoding_data.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4
pliard1
10 years, 12 months ago (2013-04-29 15:44:05 UTC) #1
Shaopeng
On 2013/04/29 15:44:05, pliard1 wrote: LGTM
10 years, 12 months ago (2013-04-29 16:21:45 UTC) #2
pliard1
On 2013/04/29 16:21:45, Shaopeng wrote: > On 2013/04/29 15:44:05, pliard1 wrote: > > LGTM Thanks ...
10 years, 12 months ago (2013-04-29 16:23:05 UTC) #3
pliard1
10 years, 12 months ago (2013-04-30 11:36:28 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r567 (presubmit successful).
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b