Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1080)

Issue 8797047: Add the 'is reviwed' badge to the charm icons

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 7 months ago by rharding
Modified:
9 years, 7 months ago
Reviewers:
mp+161426, j.c.sackett, matthew.scott
Visibility:
Public.

Description

Add the 'is reviwed' badge to the charm icons - Add the original svg given in case we need it at different sizes - Save a .png version for use in sprites - Add the check/html to the templates - Add the css in both locations, charm-token and the full charm details display. https://code.launchpad.net/~rharding/juju-gui/reviewed-indicator/+merge/161426 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Add the 'is reviwed' badge to the charm icons #

Total comments: 3

Patch Set 3 : Add the 'is reviwed' badge to the charm icons #

Patch Set 4 : Add the 'is reviwed' badge to the charm icons #

Unified diffs Side-by-side diffs Delta from patch set Stats (+177 lines, -1 line) Patch
A [revision details] View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
A app/assets/images/badge-approved.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A app/assets/images/non-sprites/badge-approved.svg View 1 chunk +144 lines, -0 lines 0 comments Download
M app/subapps/browser/templates/browser_charm.handlebars View 1 2 1 chunk +6 lines, -1 line 0 comments Download
M app/templates/charm-token.handlebars View 1 2 1 chunk +5 lines, -1 line 0 comments Download
M app/widgets/charm-token.js View 1 chunk +8 lines, -0 lines 0 comments Download
M lib/views/browser/charm-full.less View 1 2 1 chunk +7 lines, -0 lines 0 comments Download
M lib/views/browser/charm-token.less View 1 2 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 8
rharding
Please take a look.
9 years, 7 months ago (2013-04-29 13:21:15 UTC) #1
rharding
Please take a look.
9 years, 7 months ago (2013-04-29 14:28:25 UTC) #2
j.c.sackett
https://codereview.appspot.com/8797047/diff/3001/app/subapps/browser/templates/browser_charm.handlebars File app/subapps/browser/templates/browser_charm.handlebars (right): https://codereview.appspot.com/8797047/diff/3001/app/subapps/browser/templates/browser_charm.handlebars#newcode23 app/subapps/browser/templates/browser_charm.handlebars:23: <i class="sprite badge-approved"></i> Why are we using an italics ...
9 years, 7 months ago (2013-04-29 14:39:48 UTC) #3
rharding
Comment below. https://codereview.appspot.com/8797047/diff/3001/app/subapps/browser/templates/browser_charm.handlebars File app/subapps/browser/templates/browser_charm.handlebars (right): https://codereview.appspot.com/8797047/diff/3001/app/subapps/browser/templates/browser_charm.handlebars#newcode23 app/subapps/browser/templates/browser_charm.handlebars:23: <i class="sprite badge-approved"></i> On 2013/04/29 14:39:48, j.c.sackett ...
9 years, 7 months ago (2013-04-29 14:59:39 UTC) #4
rharding
Please take a look.
9 years, 7 months ago (2013-04-29 14:59:55 UTC) #5
j.c.sackett
On 2013/04/29 14:59:39, rharding wrote: > Comment below. > > https://codereview.appspot.com/8797047/diff/3001/app/subapps/browser/templates/browser_charm.handlebars > File app/subapps/browser/templates/browser_charm.handlebars (right): ...
9 years, 7 months ago (2013-04-29 15:00:52 UTC) #6
matthew.scott
LGTM - thanks for the branch
9 years, 7 months ago (2013-04-29 15:35:04 UTC) #7
rharding
9 years, 7 months ago (2013-04-29 16:05:49 UTC) #8
*** Submitted:

Add the 'is reviwed' badge to the charm icons

- Add the original svg given in case we need it at different sizes
- Save a .png version for use in sprites
- Add the check/html to the templates
- Add the css in both locations, charm-token and the full charm details
display.

R=j.c.sackett, matthew.scott
CC=
https://codereview.appspot.com/8797047
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b