Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(210)

Issue 8797043: Support resolving errors on the Go back-end.

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 11 months ago by benji
Modified:
10 years, 11 months ago
Reviewers:
mp+159162, matthew.scott, gary.poster
Visibility:
Public.

Description

Support resolving errors on the Go back-end. https://code.launchpad.net/~benji/juju-gui/go-resolved/+merge/159162 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 2

Patch Set 2 : Support resolving errors on the Go back-end. #

Total comments: 1

Patch Set 3 : Support resolving errors on the Go back-end. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+107 lines, -14 lines) Patch
A [revision details] View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M app/store/env/go.js View 1 15 chunks +70 lines, -14 lines 0 comments Download
M test/test_env_go.js View 1 1 chunk +35 lines, -0 lines 0 comments Download

Messages

Total messages: 6
benji
Please take a look.
10 years, 11 months ago (2013-04-16 14:11:05 UTC) #1
matthew.scott
LGTM - thanks for the branch. https://codereview.appspot.com/8797043/diff/1/app/store/env/go.js File app/store/env/go.js (right): https://codereview.appspot.com/8797043/diff/1/app/store/env/go.js#newcode896 app/store/env/go.js:896: err: !!data.Error, I ...
10 years, 11 months ago (2013-04-16 14:30:47 UTC) #2
benji
Thanks for the review Matt. I've fixed the problem you pointed out. https://codereview.appspot.com/8797043/diff/1/app/store/env/go.js File app/store/env/go.js ...
10 years, 11 months ago (2013-04-16 14:34:33 UTC) #3
benji
Please take a look.
10 years, 11 months ago (2013-04-16 14:37:05 UTC) #4
gary.poster
LGTM. Thank you! Gary https://codereview.appspot.com/8797043/diff/6001/app/store/env/go.js File app/store/env/go.js (right): https://codereview.appspot.com/8797043/diff/6001/app/store/env/go.js#newcode872 app/store/env/go.js:872: Retry: !!retry Javascript, you so ...
10 years, 11 months ago (2013-04-16 14:53:42 UTC) #5
benji
10 years, 11 months ago (2013-04-16 15:04:46 UTC) #6
*** Submitted:

Support resolving errors on the Go back-end.

R=matthew.scott, gary.poster
CC=
https://codereview.appspot.com/8797043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b