Issue 87950044: code review 87950044: os/exec: make TestPipeLookPathLeak more verbose when it...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 87950044: code review 87950044: os/exec: make TestPipeLookPathLeak more verbose when it... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 1 month ago by bradfitz

Modified:
11 years, 1 month ago

Reviewers:
adg

CC:
golang-codereviews, adg, iant

Visibility:
Public.

Description

os/exec: make TestPipeLookPathLeak more verbose when it fails Trying to understand the linux-386-387 failures: http://build.golang.org/log/78a91da173c11e986b4e623527c2d0b746f4e814 Also modernize the closeOnce code with a method value, while I was looking.

Patch Set 1 #

Patch Set 2 : diff -r 45ec3243c603 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 45ec3243c603 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r c7065d3ad91a https://go.googlecode.com/hg/ #

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -12 lines)			Patch
	M	src/pkg/os/exec/exec.go	View	1	1 chunk	+8 lines, -6 lines	0 comments	Download
	M	src/pkg/os/exec/exec_test.go	View	1 2 3	2 chunks	+6 lines, -6 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

bradfitz

Hello golang-codereviews@googlegroups.com (cc: iant@golang.org), I'd like you to review this change to https://go.googlecode.com/hg/

11 years, 1 month ago (2014-04-15 16:27:53 UTC) #1

bradfitz

Actually, lies: it's not the same builder. So maybe something's different on the system.

11 years, 1 month ago (2014-04-15 16:29:24 UTC) #2

bradfitz

11 years, 1 month ago (2014-04-16 00:36:40 UTC) #4

*** Submitted as https://code.google.com/p/go/source/detail?r=8665ef4cd6dd ***

os/exec: make TestPipeLookPathLeak more verbose when it fails

Trying to understand the linux-386-387 failures:
http://build.golang.org/log/78a91da173c11e986b4e623527c2d0b746f4e814

Also modernize the closeOnce code with a method value, while I
was looking.

LGTM=adg
R=golang-codereviews, adg
CC=golang-codereviews, iant
https://codereview.appspot.com/87950044

Expand All Messages | Collapse All Messages