Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(425)

Issue 87910043: code review 87910043: go.talks: fix build; add "// +build OMIT" to many samples (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 9 months ago by adg
Modified:
6 years, 9 months ago
Reviewers:
minux1, bradfitz
CC:
golang-codereviews, bradfitz
Visibility:
Public.

Description

go.talks: fix build; add "// +build OMIT" to many samples We use OMIT instead of ignore so such lines will be omitted from present output.

Patch Set 1 #

Patch Set 2 : diff -r 64c0764808ba https://code.google.com/p/go.talks #

Patch Set 3 : diff -r 64c0764808ba https://code.google.com/p/go.talks #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -0 lines) Patch
M 2013/distsys/addr1.go View 1 1 chunk +2 lines, -0 lines 0 comments Download
M 2013/distsys/addr2.go View 1 1 chunk +2 lines, -0 lines 0 comments Download
M 2013/distsys/addr3.go View 1 1 chunk +2 lines, -0 lines 0 comments Download
M 2013/distsys/addr4.go View 1 1 chunk +2 lines, -0 lines 0 comments Download
M 2013/distsys/addr5.go View 1 1 chunk +2 lines, -0 lines 0 comments Download
M 2013/distsys/finger.go View 1 1 chunk +2 lines, -0 lines 0 comments Download
M 2013/distsys/hello.go View 1 1 chunk +2 lines, -0 lines 0 comments Download
M 2013/distsys/hello0.go View 1 1 chunk +2 lines, -0 lines 0 comments Download
M 2013/distsys/hello1.go View 1 1 chunk +3 lines, -0 lines 0 comments Download
M 2013/distsys/replread.go View 1 1 chunk +2 lines, -0 lines 0 comments Download
M 2013/distsys/replwrite.go View 1 1 chunk +2 lines, -0 lines 0 comments Download
M 2013/distsys/writebuffer.go View 1 1 chunk +2 lines, -0 lines 0 comments Download
M 2013/distsys/writebuffer2.go View 1 1 chunk +2 lines, -0 lines 0 comments Download
M 2013/go-sreops/goroutines.go View 1 1 chunk +2 lines, -0 lines 0 comments Download
M 2013/go-sreops/goroutines-channels.go View 1 1 chunk +2 lines, -0 lines 0 comments Download
M 2013/go-sreops/hello.go View 1 1 chunk +2 lines, -0 lines 0 comments Download
M 2013/go4python/deco.go View 1 1 chunk +2 lines, -0 lines 0 comments Download
M 2013/go4python/decoex.go View 1 1 chunk +2 lines, -0 lines 0 comments Download
M 2013/go4python/fib.go View 1 1 chunk +2 lines, -0 lines 0 comments Download
M 2013/go4python/fib-gen.go View 1 1 chunk +2 lines, -0 lines 0 comments Download
M 2013/go4python/fib-gen2.go View 1 1 chunk +2 lines, -0 lines 0 comments Download
M 2013/go4python/genex.go View 1 1 chunk +2 lines, -0 lines 0 comments Download
M 2013/go4python/genex2.go View 1 1 chunk +2 lines, -0 lines 0 comments Download
M 2013/go4python/monkey.go View 1 1 chunk +2 lines, -0 lines 0 comments Download
M 2013/go4python/typesandmethods.go View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 5
adg
Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go.talks
6 years, 9 months ago (2014-04-15 00:55:53 UTC) #1
adg
Hello golang-codereviews@googlegroups.com (cc: golang-codereviews@googlegroups.com), Please take another look.
6 years, 9 months ago (2014-04-15 01:00:43 UTC) #2
bradfitz
LGTM On Apr 14, 2014 6:00 PM, <adg@golang.org> wrote: > Hello golang-codereviews@googlegroups.com (cc: > golang-codereviews@googlegroups.com), ...
6 years, 9 months ago (2014-04-15 01:38:18 UTC) #3
adg
*** Submitted as https://code.google.com/p/go/source/detail?r=2b96b82cd80d&repo=talks *** go.talks: fix build; add "// +build OMIT" to many samples ...
6 years, 9 months ago (2014-04-15 01:43:46 UTC) #4
minux1
6 years, 9 months ago (2014-04-15 05:52:31 UTC) #5
LGTM.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b