Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(715)

Issue 87900045: code review 87900045: cmd/ld: attempt at fixing openbsd build (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 1 month ago by rsc
Modified:
11 years, 1 month ago
Reviewers:
iant
CC:
golang-codereviews
Visibility:
Public.

Description

cmd/ld: attempt at fixing openbsd build OpenBSD is excluded from all the usual thread-local storage code, not just emitting the tbss section in the external link .o but emitting a PT_TLS section in an internally-linked executable. I assume it just has no proper TLS support. Exclude it here too.

Patch Set 1 #

Patch Set 2 : diff -r c7a9e9243878 https://code.google.com/p/go/ #

Patch Set 3 : diff -r 5db28b080054 https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M src/cmd/ld/data.c View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3
rsc
Hello iant (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/
11 years, 1 month ago (2014-04-15 19:52:21 UTC) #1
rsc
*** Submitted as https://code.google.com/p/go/source/detail?r=8e5787506b59 *** cmd/ld: attempt at fixing openbsd build OpenBSD is excluded from ...
11 years, 1 month ago (2014-04-15 19:52:27 UTC) #2
iant
11 years, 1 month ago (2014-04-15 19:57:00 UTC) #3
Message was sent while issue was closed.
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b