Issue 87860047: cmd/jujud: enable HA

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 87860047: cmd/jujud: enable HA

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years ago by rog

Modified:
10 years ago

Reviewers:
gz, natefinch, mp+216362

Visibility:
Public.

Description

cmd/jujud: enable HA Let's see what happens... https://code.launchpad.net/~rogpeppe/juju-core/540-enable-HA/+merge/216362 Requires: https://code.launchpad.net/~rogpeppe/juju-core/557-peergrouper-maintain-hasvote/+merge/216359 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : cmd/jujud: enable HA #

Created: 10 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+63 lines, -21 lines)			Patch
A	[revision details]	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	cmd/juju/main.go	View		1 chunk	+1 line, -1 line	0 comments	Download
M	cmd/juju/main_test.go	View		3 chunks	+3 lines, -1 line	0 comments	Download
M	cmd/jujud/bootstrap_test.go	View		3 chunks	+2 lines, -6 lines	0 comments	Download
M	cmd/jujud/machine.go	View		7 chunks	+14 lines, -8 lines	0 comments	Download
M	cmd/jujud/machine_test.go	View		4 chunks	+33 lines, -1 line	0 comments	Download
M	cmd/jujud/unit_test.go	View		1 chunk	+1 line, -1 line	0 comments	Download
M	state/api/apiclient.go	View		1 chunk	+1 line, -1 line	0 comments	Download
M	state/open.go	View		2 chunks	+1 line, -1 line	0 comments	Download
M	worker/singular/singular.go	View		4 chunks	+5 lines, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

LGTM. Rather random set of changes, but they all seem reasonable.

Expand All Messages | Collapse All Messages