Issue 8770044: Potpourri, see below.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 8770044: Potpourri, see below.

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years ago by benji

Modified:
11 years ago

Reviewers:
mp+158949, jeff.pihach, gary.poster

Visibility:
Public.

Description

Potpourri, see below. - elide some of the unnecessary commentary from the linter - add a bug number to a XXX - change a Y.Object.each to Y.Array.each https://code.launchpad.net/~benji/juju-gui/potpourri/+merge/158949 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Potpourri, see below. #

Created: 11 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+12 lines, -7 lines)			Patch
M	Makefile	View	2 chunks	+7 lines, -5 lines	0 comments	Download
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	app/models/handlers.js	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	app/views/service.js	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

gary.poster

LGTM. Thank you! I did not QA; if you would like me to, let me ...

11 years ago (2013-04-15 15:05:56 UTC) #3

benji

11 years ago (2013-04-15 15:14:14 UTC) #4

*** Submitted:

Potpourri, see below.

- elide some of the unnecessary commentary from the linter
- add a bug number to a XXX
- change a Y.Object.each to Y.Array.each

R=jeff.pihach, gary.poster
CC=
https://codereview.appspot.com/8770044

Expand All Messages | Collapse All Messages