Issue 8768045: state: don't log inside dial func

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 8768045: state: don't log inside dial func

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years ago by fwereade

Modified:
11 years ago

Reviewers:
mp+159405, dimitern, TheMue

Visibility:
Public.

Description

state: don't log inside dial func ...because mgo keeps on trying to dial every address every 30s, and 240 lines/agent/hour is a bit much. https://code.launchpad.net/~fwereade/juju-core/less-state-logging/+merge/159405 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : state: don't log inside dial func #

Created: 11 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -2 lines)			Patch
	A	[revision details]	View		1 chunk	+2 lines, -0 lines	0 comments	Download
	M	state/open.go	View		3 chunks	+1 line, -2 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

fwereade

11 years ago (2013-04-17 14:58:10 UTC) #4

*** Submitted:

state: don't log inside dial func

...because mgo keeps on trying to dial every address every 30s, and 240
lines/agent/hour is a bit much.

R=TheMue
CC=
https://codereview.appspot.com/8768045

Expand All Messages | Collapse All Messages