Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(451)

Issue 8768043: Fix peer relation names handling.

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 11 months ago by frankban
Modified:
10 years, 11 months ago
Reviewers:
mp+158910, benji, gary.poster
Visibility:
Public.

Description

Fix peer relation names handling. Improved the way the GUI checks whether a relation name is a PyJuju one or a juju-core one. This fixes the wrong "relation:NaN" label that was used to represent peer relations. https://code.launchpad.net/~frankban/juju-gui/bug-1168449-releation-names/+merge/158910 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fix peer relation names handling. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -8 lines) Patch
A [revision details] View 1 1 chunk +2 lines, -0 lines 0 comments Download
M app/views/utils.js View 2 chunks +17 lines, -4 lines 0 comments Download
M test/test_utils.js View 1 chunk +28 lines, -4 lines 0 comments Download

Messages

Total messages: 5
frankban
Please take a look.
10 years, 11 months ago (2013-04-15 12:39:14 UTC) #1
gary.poster
LGTM, thank you.
10 years, 11 months ago (2013-04-15 12:47:02 UTC) #2
benji
Looks good. (LGTM feels impersonal.) https://codereview.appspot.com/8768043/diff/1/test/test_utils.js File test/test_utils.js (right): https://codereview.appspot.com/8768043/diff/1/test/test_utils.js#newcode118 test/test_utils.js:118: describe('isPythonRelation', function() { Nice ...
10 years, 11 months ago (2013-04-15 12:56:07 UTC) #3
frankban
*** Submitted: Fix peer relation names handling. Improved the way the GUI checks whether a ...
10 years, 11 months ago (2013-04-15 13:11:52 UTC) #4
frankban
10 years, 11 months ago (2013-04-15 13:12:47 UTC) #5
Thank you both for the reviews!
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b