Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(13)

Issue 87670044: code review 87670044: liblink: remove arch-specific constants from file format (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 1 month ago by rsc
Modified:
11 years, 1 month ago
Reviewers:
iant
CC:
iant, golang-codereviews
Visibility:
Public.

Description

liblink: remove arch-specific constants from file format The relocation and automatic variable types were using arch-specific numbers. Introduce portable enumerations instead. To the best of my knowledge, these are the only arch-specific bits left in the new object file format. Remove now, before Go 1.3, because file formats are forever.

Patch Set 1 #

Patch Set 2 : diff -r 7021258fb723 https://code.google.com/p/go/ #

Total comments: 1

Patch Set 3 : diff -r 8aad251d4bd1 https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+151 lines, -154 lines) Patch
M include/link.h View 1 2 chunks +24 lines, -2 lines 0 comments Download
M src/cmd/5l/5.out.h View 1 1 chunk +0 lines, -10 lines 0 comments Download
M src/cmd/5l/asm.c View 1 12 chunks +26 lines, -26 lines 0 comments Download
M src/cmd/6l/6.out.h View 1 1 chunk +0 lines, -4 lines 0 comments Download
M src/cmd/6l/asm.c View 1 14 chunks +17 lines, -17 lines 0 comments Download
M src/cmd/8l/8.out.h View 1 1 chunk +0 lines, -5 lines 0 comments Download
M src/cmd/8l/asm.c View 1 10 chunks +22 lines, -22 lines 0 comments Download
M src/cmd/ld/data.c View 1 6 chunks +7 lines, -7 lines 0 comments Download
M src/cmd/ld/dwarf.c View 1 2 chunks +3 lines, -3 lines 0 comments Download
M src/cmd/ld/ldmacho.c View 1 1 chunk +1 line, -1 line 0 comments Download
M src/cmd/ld/ldpe.c View 1 1 chunk +3 lines, -3 lines 0 comments Download
M src/cmd/ld/lib.c View 1 1 chunk +2 lines, -2 lines 0 comments Download
M src/cmd/link/load.go View 1 2 chunks +6 lines, -12 lines 0 comments Download
M src/cmd/link/pclntab.go View 1 1 chunk +1 line, -1 line 0 comments Download
M src/cmd/link/testdata/autosection.6 View 1 Binary file 0 comments Download
M src/cmd/link/testdata/autoweak.6 View 1 Binary file 0 comments Download
M src/cmd/link/testdata/dead.6 View 1 Binary file 0 comments Download
M src/cmd/link/testdata/hello.6 View 1 Binary file 0 comments Download
M src/cmd/link/testdata/layout.6 View 1 Binary file 0 comments Download
M src/cmd/link/testdata/pclntab.6 View 1 Binary file 0 comments Download
M src/liblink/asm5.c View 1 3 chunks +6 lines, -6 lines 0 comments Download
M src/liblink/asm6.c View 1 4 chunks +6 lines, -6 lines 0 comments Download
M src/liblink/asm8.c View 1 2 5 chunks +5 lines, -5 lines 0 comments Download
M src/liblink/data.c View 1 6 chunks +7 lines, -9 lines 0 comments Download
M src/liblink/obj5.c View 1 1 chunk +2 lines, -2 lines 0 comments Download
M src/liblink/obj6.c View 1 2 chunks +4 lines, -4 lines 0 comments Download
M src/liblink/obj8.c View 1 1 chunk +2 lines, -2 lines 0 comments Download
M src/liblink/objfile.c View 1 2 2 chunks +7 lines, -5 lines 0 comments Download

Messages

Total messages: 3
rsc
Hello iant (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/
11 years, 1 month ago (2014-04-14 18:20:16 UTC) #1
iant
LGTM https://codereview.appspot.com/87670044/diff/20001/src/liblink/objfile.c File src/liblink/objfile.c (right): https://codereview.appspot.com/87670044/diff/20001/src/liblink/objfile.c#newcode88 src/liblink/objfile.c:88: // the only field with architecture-dependent meaning is ...
11 years, 1 month ago (2014-04-14 19:08:52 UTC) #2
rsc
11 years, 1 month ago (2014-04-14 19:54:23 UTC) #3
*** Submitted as https://code.google.com/p/go/source/detail?r=43e3e60918e4 ***

liblink: remove arch-specific constants from file format

The relocation and automatic variable types were using
arch-specific numbers. Introduce portable enumerations
instead.

To the best of my knowledge, these are the only arch-specific
bits left in the new object file format.

Remove now, before Go 1.3, because file formats are forever.

LGTM=iant
R=iant
CC=golang-codereviews
https://codereview.appspot.com/87670044
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b