Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(295)

Issue 87630043: code review 87630043: cmd/dist: mark cmd/link and debug/goobj as unreleased (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 1 month ago by rsc
Modified:
11 years, 1 month ago
Reviewers:
bradfitz
CC:
golang-codereviews, bradfitz, minux1, iant, r
Visibility:
Public.

Description

cmd/dist: mark cmd/link and debug/goobj as unreleased These are not ready and will not be in Go 1.3. Fixes issue 6932.

Patch Set 1 #

Patch Set 2 : diff -r 9d94bbf68821 https://code.google.com/p/go/ #

Patch Set 3 : diff -r 9d94bbf68821 https://code.google.com/p/go/ #

Patch Set 4 : diff -r 9d94bbf68821 https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M src/cmd/dist/build.c View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7
rsc
Hello golang-codereviews@googlegroups.com (cc: iant, r), I'd like you to review this change to https://code.google.com/p/go/
11 years, 1 month ago (2014-04-14 15:12:28 UTC) #1
bradfitz
LGTM On Mon, Apr 14, 2014 at 8:12 AM, <rsc@golang.org> wrote: > Reviewers: golang-codereviews, > ...
11 years, 1 month ago (2014-04-14 15:15:34 UTC) #2
minux1
misc/makerelease also needs change, ni?
11 years, 1 month ago (2014-04-14 16:21:26 UTC) #3
minux1
On Apr 14, 2014 12:21 PM, "minux" <minux.ma@gmail.com> wrote: > misc/makerelease also needs change, ni? ...
11 years, 1 month ago (2014-04-14 16:26:17 UTC) #4
rsc
I don't actually know what else needs to change. I know that this will catch ...
11 years, 1 month ago (2014-04-14 16:33:32 UTC) #5
rsc
*** Submitted as https://code.google.com/p/go/source/detail?r=951c55f1bd60 *** cmd/dist: mark cmd/link and debug/goobj as unreleased These are not ...
11 years, 1 month ago (2014-04-14 16:33:46 UTC) #6
minux1
11 years, 1 month ago (2014-04-14 17:32:16 UTC) #7
On Apr 14, 2014 12:33 PM, "Russ Cox" <rsc@golang.org> wrote:
> I don't actually know what else needs to change. I know that this will
catch it.
besides misc/makerelease, i think we shouldn't put debug/goobj api into
api/next.txt (at least not to go1.3.txt)

maybe we need a separate api file for unreleased APIs.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b