code review 8757045: bufio.Scan: don't stop after Read returns 0, nil

bufio.Scan: don't stop after Read returns 0, nil
But stop eventually if the reader misbehaves.

[r, 2013-04-18 04:43:25]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go/

[bradfitz, 2013-04-18 06:09:14]

LGTM with caveat.

But thanks for this. I'm very happy with this new behavior.

https://codereview.appspot.com/8757045/diff/3001/src/pkg/bufio/scan.go
File src/pkg/bufio/scan.go (right):

https://codereview.appspot.com/8757045/diff/3001/src/pkg/bufio/scan.go#newcode64
src/pkg/bufio/scan.go:64: ErrBadReader       = errors.New("bufio.Scanner: Reader
sends endless empty reads")
as long as we're adding API, I wouldn't mind this being in the io package too.

but if the argument is that it's not worth being exported API in the io package,
why here? if the argument is that this is rare enough to never need ==, then
this could be unexported.

exported but only in bufio seems a little odd, since it's not bufio-specific at
all.

[r, 2013-04-19 00:21:29]

Hello golang-dev@googlegroups.com, bradfitz@golang.org (cc:
golang-dev@googlegroups.com),

Please take another look.

[bradfitz, 2013-04-19 00:30:20]

LGTM

[r, 2013-04-19 00:37:25]

*** Submitted as https://code.google.com/p/go/source/detail?r=13e00572ed0b ***

bufio.Scan: don't stop after Read returns 0, nil
But stop eventually if the reader misbehaves.

R=golang-dev, bradfitz
CC=golang-dev
https://codereview.appspot.com/8757045