code review 87570044: crypto/x509: fix Windows build.

crypto/x509: fix Windows build.

Windows is building a chain to the AddTrust root which is different
from the native Go code and causing a build failure.

This change alters the test so that both should build to the AddTrust
root.

R=bradfitz

[agl1, 2014-04-14 20:15:41]

Hello golang-codereviews@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go

[bradfitz, 2014-04-14 20:19:19]

LGTM

Btw, the R= in your CL description doesn't do what you might think. You'll
want to use the hg change fields for that, so I actually get the email To:
or Cc: me, else people filter them away.



On Mon, Apr 14, 2014 at 1:15 PM, <agl@golang.org> wrote:

> Reviewers: golang-codereviews,
>
> Message:
> Hello golang-codereviews@googlegroups.com,
>
> I'd like you to review this change to
> https://code.google.com/p/go
>
>
> Description:
> crypto/x509: fix Windows build.
>
> Windows is building a chain to the AddTrust root which is different
> from the native Go code and causing a build failure.
>
> This change alters the test so that both should build to the AddTrust
> root.
>
> R=bradfitz
>
> Please review this at https://codereview.appspot.com/87570044/
>
> Affected files (+30, -3 lines):
>   M src/pkg/crypto/x509/verify_test.go
>
>
> Index: src/pkg/crypto/x509/verify_test.go
> ===================================================================
> --- a/src/pkg/crypto/x509/verify_test.go
> +++ b/src/pkg/crypto/x509/verify_test.go
> @@ -213,8 +213,8 @@
>                 // Check that SHA-384 intermediates (which are popping up)
>                 // work.
>                 leaf:          moipLeafCert,
> -               intermediates: []string{comodoIntermediateSHA384},
> -               roots:         []string{comodoRSARoot},
> +               intermediates: []string{comodoIntermediateSHA384,
> comodoRSAAuthority},
> +               roots:         []string{addTrustRoot},
>                 currentTime:   1397502195,
>                 dnsName:       "api.moip.com.br",
>
> @@ -223,6 +223,7 @@
>                                 "api.moip.com.br",
>                                 "COMODO RSA Extended Validation Secure
> Server CA",
>                                 "COMODO RSA Certification Authority",
> +                               "AddTrust External CA Root",
>                         },
>                 },
>         },
> @@ -1062,7 +1063,7 @@
>  pLwltum95OmYdBbxN4SBB7SC
>  -----END CERTIFICATE-----`
>
> -const comodoRSARoot = `-----BEGIN CERTIFICATE-----
> +const comodoRSAAuthority = `-----BEGIN CERTIFICATE-----
>  MIIFdDCCBFygAwIBAgIQJ2buVutJ846r13Ci/ITeIjANBgkqhkiG9w0BAQwFADBv
>  MQswCQYDVQQGEwJTRTEUMBIGA1UEChMLQWRkVHJ1c3QgQUIxJjAkBgNVBAsTHUFk
>  ZFRydXN0IEV4dGVybmFsIFRUUCBOZXR3b3JrMSIwIAYDVQQDExlBZGRUcnVzdCBF
> @@ -1094,3 +1095,29 @@
>  PUsE2JOAWVrgQSQdso8VYFhH2+9uRv0V9dlfmrPb2LjkQLPNlzmuhbsdjrzch5vR
>  pu/xO28QOG8=
>  -----END CERTIFICATE-----`
> +
> +const addTrustRoot = `-----BEGIN CERTIFICATE-----
> +MIIENjCCAx6gAwIBAgIBATANBgkqhkiG9w0BAQUFADBvMQswCQYDVQQGEwJTRTEU
> +MBIGA1UEChMLQWRkVHJ1c3QgQUIxJjAkBgNVBAsTHUFkZFRydXN0IEV4dGVybmFs
> +IFRUUCBOZXR3b3JrMSIwIAYDVQQDExlBZGRUcnVzdCBFeHRlcm5hbCBDQSBSb290
> +MB4XDTAwMDUzMDEwNDgzOFoXDTIwMDUzMDEwNDgzOFowbzELMAkGA1UEBhMCU0Ux
> +FDASBgNVBAoTC0FkZFRydXN0IEFCMSYwJAYDVQQLEx1BZGRUcnVzdCBFeHRlcm5h
> +bCBUVFAgTmV0d29yazEiMCAGA1UEAxMZQWRkVHJ1c3QgRXh0ZXJuYWwgQ0EgUm9v
> +dDCCASIwDQYJKoZIhvcNAQEBBQADggEPADCCAQoCggEBALf3GjPm8gAELTngTlvt
> +H7xsD821+iO2zt6bETOXpClMfZOfvUq8k+0DGuOPz+VtUFrWlymUWoCwSXrbLpX9
> +uMq/NzgtHj6RQa1wVsfwTz/oMp50ysiQVOnGXw94nZpAPA6sYapeFI+eh6FqUNzX
> +mk6vBbOmcZSccbNQYArHE504B4YCqOmoaSYYkKtMsE8jqzpPhNjfzp/haW+710LX
> +a0Tkx63ubUFfclpxCDezeWWkWaCUN/cALw3CknLa0Dhy2xSoRcRdKn23tNbE7qzN
> +E0S3ySvdQwAl+mG5aWpYIxG3pzOPVnVZ9c0p10a3CitlttNCbxWyuHv77+ldU9U0
> +WicCAwEAAaOB3DCB2TAdBgNVHQ4EFgQUrb2YejS0Jvf6xCZU7wO94CTLVBowCwYD
> +VR0PBAQDAgEGMA8GA1UdEwEB/wQFMAMBAf8wgZkGA1UdIwSBkTCBjoAUrb2YejS0
> +Jvf6xCZU7wO94CTLVBqhc6RxMG8xCzAJBgNVBAYTAlNFMRQwEgYDVQQKEwtBZGRU
> +cnVzdCBBQjEmMCQGA1UECxMdQWRkVHJ1c3QgRXh0ZXJuYWwgVFRQIE5ldHdvcmsx
> +IjAgBgNVBAMTGUFkZFRydXN0IEV4dGVybmFsIENBIFJvb3SCAQEwDQYJKoZIhvcN
> +AQEFBQADggEBALCb4IUlwtYj4g+WBpKdQZic2YR5gdkeWxQHIzZlj7DYd7usQWxH
> +YINRsPkyPef89iYTx4AWpb9a/IfPeHmJIZriTAcKhjW88t5RxNKWt9x+Tu5w/Rw5
> +6wwCURQtjr0W4MHfRnXnJK3s9EK0hZNwEGe6nQY1ShjTK3rMUUKhemPR5ruhxSvC
> +Nr4TDea9Y355e6cJDUCrat2PisP29owaQgVR1EX1n6diIWgVIEM8med8vSTYqZEX
> +c4g/VhsxOBi0cQ+azcgOno4uG+GMmIPLHzHxREzGBHNJdmAPx/i9F4BrLunMTA5a
> +mnkPIAou1Z5jJh5VkpTYghdae9C8x49OhgQ=
> +-----END CERTIFICATE-----`
>
>
> --
> You received this message because you are subscribed to the Google Groups
> "golang-codereviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-codereviews+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>

[agl1, 2014-04-14 20:24:03]

*** Submitted as https://code.google.com/p/go/source/detail?r=fa4c16e1888b ***

crypto/x509: fix Windows build.

Windows is building a chain to the AddTrust root which is different
from the native Go code and causing a build failure.

This change alters the test so that both should build to the AddTrust
root.

R=bradfitz

LGTM=bradfitz
R=golang-codereviews, bradfitz
CC=golang-codereviews
https://codereview.appspot.com/87570044

[gobot, 2014-04-15 15:10:33]

This CL appears to have broken the freebsd-arm-cheney builder.
See http://build.golang.org/log/55431b75d92149b972d77b44dd3e43aa4f1c5aaf