Issue 87470044: state: Networking improvements, missed before

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 87470044: state: Networking improvements, missed before (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years ago by dimitern

Modified:
10 years ago

Reviewers:
mp+215660, rog

Visibility:
Public.

Description

state: Networking improvements, missed before In this CL https://codereview.appspot.com/86010044/, some of the suggestions regarding implementation details of AddNetwork and AddNetworkInterface were not included in time. This adds these suggestions. https://code.launchpad.net/~dimitern/juju-core/397-state-networking/+merge/215660 Requires: https://code.launchpad.net/~dimitern/juju-core/396-improve-errors/+merge/215652 (do not edit description out of merge proposal)

Patch Set 1 #

Created: 10 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+37 lines, -35 lines)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	state/machine.go	View	1 chunk	+29 lines, -31 lines	0 comments	Download
M	state/state.go	View	1 chunk	+6 lines, -4 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

rog

10 years ago (2014-04-14 13:24:25 UTC) #2

On 2014/04/14 13:15:13, dimitern wrote:
> Please take a look.

LGTM, thanks.

Expand All Messages | Collapse All Messages