Implement the fakebackend add_relation method

Implement the fakebackend add_relation method

The add_relation functionality has now been implemented
in the fakebackend and pyJuju sandbox. It allows all of the
current functionality currently required by the GUI but also
implements the ability to handle inferred relationships.

https://code.launchpad.net/~hatch/juju-gui/ar-inferred/+merge/158732

(do not edit description out of merge proposal)

[jeff.pihach, 2013-04-13 00:20:19]

Please take a look.

[jeff.pihach, 2013-04-15 22:17:11]

Please take a look.

[bcsaller, 2013-04-15 22:36:58]

LGTM

You really reworked this since I last looked at it. Much better. Easier to
follow and the test clean up is nice. Thank you.

https://codereview.appspot.com/8735043/diff/3001/app/store/env/fakebackend.js
File app/store/env/fakebackend.js (right):

https://codereview.appspot.com/8735043/diff/3001/app/store/env/fakebackend.js...
app/store/env/fakebackend.js:33: requiringEndpoint = endpoints[!providedIndex +
0],
!0 + 0, oh JS... heh

https://codereview.appspot.com/8735043/diff/3001/app/store/env/fakebackend.js...
app/store/env/fakebackend.js:65: });
nicer, thanks.

https://codereview.appspot.com/8735043/diff/3001/app/store/env/sandbox.js
File app/store/env/sandbox.js (right):

https://codereview.appspot.com/8735043/diff/3001/app/store/env/sandbox.js#new...
app/store/env/sandbox.js:574: epA[relation.endpoints[0][0]] =
relation.endpoints[0][1];
trivial: I expect this will be difficult to return to w/o a comment showing
saying what its doing.

// Normalize endpoints such that {...: {...}}

https://codereview.appspot.com/8735043/diff/3001/test/test_fakebackend.js
File test/test_fakebackend.js (right):

https://codereview.appspot.com/8735043/diff/3001/test/test_fakebackend.js#new...
test/test_fakebackend.js:726: done();
You assert result.error but you could have also passed it to done which would
tell mocha the test failed with an error. No need to change anything but it can
be a nice feature.

https://codereview.appspot.com/8735043/diff/3001/test/test_fakebackend.js#new...
test/test_fakebackend.js:958: });
Much nicer test setup, thank you.

https://codereview.appspot.com/8735043/diff/3001/test/utils.js
File test/utils.js (right):

https://codereview.appspot.com/8735043/diff/3001/test/utils.js#newcode97
test/utils.js:97: 'hadoop']);
When it grows up can it be a real charm store? :)

[jeff.pihach, 2013-04-15 22:48:16]

Thanks for the review!

https://codereview.appspot.com/8735043/diff/3001/app/store/env/sandbox.js
File app/store/env/sandbox.js (right):

https://codereview.appspot.com/8735043/diff/3001/app/store/env/sandbox.js#new...
app/store/env/sandbox.js:574: epA[relation.endpoints[0][0]] =
relation.endpoints[0][1];
On 2013/04/15 22:36:58, bcsaller wrote:
> trivial: I expect this will be difficult to return to w/o a comment showing
> saying what its doing.
> 
> // Normalize endpoints such that {...: {...}}
> 

Done.

https://codereview.appspot.com/8735043/diff/3001/test/test_fakebackend.js
File test/test_fakebackend.js (right):

https://codereview.appspot.com/8735043/diff/3001/test/test_fakebackend.js#new...
test/test_fakebackend.js:726: done();
cool I didn't know that.

https://codereview.appspot.com/8735043/diff/3001/test/utils.js
File test/utils.js (right):

https://codereview.appspot.com/8735043/diff/3001/test/utils.js#newcode97
test/utils.js:97: 'hadoop']);
haha, maybe some day

[jeff.pihach, 2013-04-15 22:53:48]

*** Submitted:

Implement the fakebackend add_relation method

The add_relation functionality has now been implemented
in the fakebackend and pyJuju sandbox. It allows all of the
current functionality currently required by the GUI but also
implements the ability to handle inferred relationships.

R=bcsaller
CC=
https://codereview.appspot.com/8735043