enabled gtfs exporting

[calidion, 2010-04-09 03:12:12]

Enabled gtfs exporting
and now the export of gtfs objects to gtfs feed is a very simple process, which
only need one for loop and one sql statement for each GTFS Object.

[weiliu, 2010-04-09 03:26:17]

LGTM for python code.

http://codereview.appspot.com/873044/diff/1/3
File transitfeed_editor.py (right):

http://codereview.appspot.com/873044/diff/1/3#newcode862
transitfeed_editor.py:862: def ExportGTFSDataToTextFile(self, archive,
gtfsClass):
If my understanding is correct, archive is for output, gtfsClass is input,
right? If yes, please put input param before the output params.

[calidion, 2010-04-09 05:42:37]

1. change the bounce time for gdirection
2. updated on comments

http://codereview.appspot.com/873044/diff/1/3
File transitfeed_editor.py (right):

http://codereview.appspot.com/873044/diff/1/3#newcode862
transitfeed_editor.py:862: def ExportGTFSDataToTextFile(self, archive,
gtfsClass):
On 2010/04/09 03:26:17, weiliu wrote:
> If my understanding is correct, archive is for output, gtfsClass is input,
> right? If yes, please put input param before the output params.

Done.

[baiming, 2010-04-09 07:17:46]

Only a few minor comments, otherwise it looks good.

http://codereview.appspot.com/873044/diff/5001/6001
File gtfsscheduleviewer/files/transit_editor.js (right):

http://codereview.appspot.com/873044/diff/5001/6001#newcode59
gtfsscheduleviewer/files/transit_editor.js:59: dirTimer =
setTimeout(onDirTimeOut, DIRECTION_INTERVAL * (dirFailureTime + 1));
Sorry, didn't notice this before.
Please take care of this long line.

http://codereview.appspot.com/873044/diff/5001/6001#newcode81
gtfsscheduleviewer/files/transit_editor.js:81: dirTimer =
setTimeout(onDirTimeOut, DIRECTION_INTERVAL * (dirFailureTime + 1));
Ditto.

http://codereview.appspot.com/873044/diff/5001/6001#newcode4414
gtfsscheduleviewer/files/transit_editor.js:4414: var isExporting = false;
Can you please move this to where other global variables are defined, ~ line
174?

[calidion, 2010-04-12 02:19:21]

updated

http://codereview.appspot.com/873044/diff/5001/6001
File gtfsscheduleviewer/files/transit_editor.js (right):

http://codereview.appspot.com/873044/diff/5001/6001#newcode59
gtfsscheduleviewer/files/transit_editor.js:59: dirTimer =
setTimeout(onDirTimeOut, DIRECTION_INTERVAL * (dirFailureTime + 1));
On 2010/04/09 07:17:46, baiming wrote:
> Sorry, didn't notice this before.
> Please take care of this long line.

Done.

http://codereview.appspot.com/873044/diff/5001/6001#newcode81
gtfsscheduleviewer/files/transit_editor.js:81: dirTimer =
setTimeout(onDirTimeOut, DIRECTION_INTERVAL * (dirFailureTime + 1));
On 2010/04/09 07:17:46, baiming wrote:
> Ditto.

Done.

http://codereview.appspot.com/873044/diff/5001/6001#newcode4414
gtfsscheduleviewer/files/transit_editor.js:4414: var isExporting = false;
On 2010/04/09 07:17:46, baiming wrote:
> Can you please move this to where other global variables are defined, ~ line
> 174?

Done.

[baiming, 2010-04-12 02:28:25]

LGTM

[calidion, 2010-04-12 02:34:18]

updated to rev 71

2010/4/12 <baiming@google.com>

> LGTM
>
>
> http://codereview.appspot.com/873044/show
>