code review 87300043: cmd/go: do not miss an error if import path contains "c...

cmd/go: do not miss an error if import path contains "cmd/something"

Fixes issue 7638

[atom, 2014-04-12 11:05:27]

Hello rsc@golang.org (cc: golang-codereviews@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go/

[rsc, 2014-04-14 19:46:32]

LGTM

[atom, 2014-04-14 20:01:38]

*** Submitted as https://code.google.com/p/go/source/detail?r=1dc800571456 ***

cmd/go: do not miss an error if import path contains "cmd/something"

Fixes issue 7638

LGTM=rsc
R=rsc
CC=golang-codereviews
https://codereview.appspot.com/87300043

[adg, 2014-04-15 00:15:28]

This change broke "go get code.google.com/p/go.tools/..." and so on.

[adg, 2014-04-15 00:15:53]

On 2014/04/15 00:15:28, adg wrote:
> This change broke "go get code.google.com/p/go.tools/..." and so on.

Sorry that should be "go get -d code.google.com/p/go.tools/..."

[rsc, 2014-04-15 01:59:14]

Looks like you fixed the go.tools repo?

[adg, 2014-04-15 02:43:17]

I rolled back this CL.​

[rsc, 2014-04-16 02:08:38]

On Mon, Apr 14, 2014 at 10:42 PM, Andrew Gerrand <adg@golang.org> wrote:

> I rolled back this CL.​
>

I believe this CL is correct and the rollback is covering up a problem. Can
you tell us what go get -d did?

[adg, 2014-04-16 02:45:58]

I described the issue on the other thread:
https://codereview.appspot.com/87890043/#msg10




On 16 April 2014 12:08, Russ Cox <rsc@golang.org> wrote:

> On Mon, Apr 14, 2014 at 10:42 PM, Andrew Gerrand <adg@golang.org> wrote:
>
>> I rolled back this CL.​
>>
>
> I believe this CL is correct and the rollback is covering up a problem.
> Can you tell us what go get -d did?
>
>