Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(95)

Issue 8727044: environs: FindInstanceTools, FindBootstrapTools

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 11 months ago by fwereade
Modified:
11 years, 11 months ago
Reviewers:
dimitern, mp+158780
Visibility:
Public.

Description

environs: FindInstanceTools, FindBootstrapTools These funcs will replace use of FindTools/BestTools in (a) followup branch(es). Except roger doesn't like FindBootstrapTools because it has side effects, so it's EnsureAgentVersion instead, which still has side effects and isn't clearly about bootstrap any more and is inconsistent with all the other tools functions. But it's Better. https://code.launchpad.net/~fwereade/juju-core/environs-tools-provisioning/+merge/158780 Requires: https://code.launchpad.net/~fwereade/juju-core/upgrade-select-tools/+merge/158596 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 10

Patch Set 2 : environs: FindInstanceTools, FindBootstrapTools #

Patch Set 3 : environs: FindInstanceTools, FindBootstrapTools #

Unified diffs Side-by-side diffs Delta from patch set Stats (+429 lines, -21 lines) Patch
A [revision details] View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M environs/tools.go View 1 2 2 chunks +73 lines, -0 lines 0 comments Download
M environs/tools_test.go View 1 2 7 chunks +354 lines, -21 lines 0 comments Download

Messages

Total messages: 8
fwereade
Please take a look.
11 years, 11 months ago (2013-04-14 11:12:30 UTC) #1
rog
looks really good. a couple of comments below. https://codereview.appspot.com/8727044/diff/1/environs/tools.go File environs/tools.go (right): https://codereview.appspot.com/8727044/diff/1/environs/tools.go#newcode137 environs/tools.go:137: // ...
11 years, 11 months ago (2013-04-15 11:12:12 UTC) #2
dimitern
LGTM https://codereview.appspot.com/8727044/diff/1/environs/tools_test.go File environs/tools_test.go (right): https://codereview.appspot.com/8727044/diff/1/environs/tools_test.go#newcode585 environs/tools_test.go:585: var findBootstrapToolsTests = []struct { nice, exhaustive tests! ...
11 years, 11 months ago (2013-04-15 14:45:32 UTC) #3
fwereade
Please take a look. https://codereview.appspot.com/8727044/diff/1/environs/tools.go File environs/tools.go (right): https://codereview.appspot.com/8727044/diff/1/environs/tools.go#newcode137 environs/tools.go:137: // environment's configuration. On 2013/04/15 ...
11 years, 11 months ago (2013-04-16 02:29:56 UTC) #4
rog
https://codereview.appspot.com/8727044/diff/1/environs/tools.go File environs/tools.go (right): https://codereview.appspot.com/8727044/diff/1/environs/tools.go#newcode137 environs/tools.go:137: // environment's configuration. On 2013/04/16 02:29:56, fwereade wrote: > ...
11 years, 11 months ago (2013-04-16 12:25:45 UTC) #5
rog
11 years, 11 months ago (2013-04-16 12:26:49 UTC) #6
fwereade
On 2013/04/16 12:25:45, rog wrote: > presumably EnsureAgentVersion or SetAgentVersion) but something different from > ...
11 years, 11 months ago (2013-04-16 13:30:32 UTC) #7
fwereade
11 years, 11 months ago (2013-04-17 05:18:45 UTC) #8
*** Submitted:

environs: FindInstanceTools, FindBootstrapTools

These funcs will replace use of FindTools/BestTools in (a) followup
branch(es).

Except roger doesn't like FindBootstrapTools because it has side effects, so
it's EnsureAgentVersion instead, which still has side effects and isn't
clearly about bootstrap any more and is inconsistent with all the other
tools functions. But it's Better.

R=rog, dimitern
CC=
https://codereview.appspot.com/8727044
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b