Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2072)

Issue 8726051: code review 8726051: net: refactor sockets (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 11 months ago by mikio
Modified:
10 years, 7 months ago
Reviewers:
dfc, golang-dev, rsc, bradfitz
CC:
golang-dev
Visibility:
Public.

Description

net: refactor sockets

Patch Set 1 : diff -r f76748f48464 https://go.googlecode.com/hg/ #

Total comments: 1

Patch Set 2 : diff -r e7b0d65f9e5b https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r b9ee7a3df1c9 https://go.googlecode.com/hg/ #

Total comments: 2

Patch Set 4 : diff -r 23b38422a72c https://go.googlecode.com/hg/ #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+86 lines, -140 lines) Patch
M src/pkg/net/iprawsock_posix.go View 1 2 3 2 chunks +10 lines, -4 lines 1 comment Download
M src/pkg/net/ipsock_posix.go View 1 2 3 2 chunks +1 line, -22 lines 0 comments Download
M src/pkg/net/sock_posix.go View 1 2 3 1 chunk +8 lines, -39 lines 0 comments Download
M src/pkg/net/tcpsock_posix.go View 1 2 3 3 chunks +12 lines, -5 lines 0 comments Download
M src/pkg/net/udpsock_posix.go View 1 2 3 4 chunks +19 lines, -10 lines 0 comments Download
M src/pkg/net/unixsock_posix.go View 1 2 3 4 chunks +36 lines, -60 lines 0 comments Download

Messages

Total messages: 18
mikio
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
10 years, 8 months ago (2013-07-24 00:13:31 UTC) #1
bradfitz
https://codereview.appspot.com/8726051/diff/61001/src/pkg/net/ipsock_posix.go File src/pkg/net/ipsock_posix.go (right): https://codereview.appspot.com/8726051/diff/61001/src/pkg/net/ipsock_posix.go#newcode26 src/pkg/net/ipsock_posix.go:26: laddr TCPAddr these three changes here look unnecessary. smaller ...
10 years, 8 months ago (2013-07-24 01:49:52 UTC) #2
mikio
PTAL > how much else in this diff is just providing distraction? Not so much, ...
10 years, 8 months ago (2013-07-24 15:06:10 UTC) #3
dfc
On 2013/07/24 15:06:10, mikio wrote: > PTAL > > > how much else in this ...
10 years, 8 months ago (2013-07-25 11:11:59 UTC) #4
mikio
On Thu, Jul 25, 2013 at 8:11 PM, <dave@cheney.net> wrote: > 1. Unless they are ...
10 years, 8 months ago (2013-07-25 14:34:00 UTC) #5
dfc
Thanks for your comments, I'll take another pass in the morning. On 26/07/2013, at 0:33, ...
10 years, 8 months ago (2013-07-25 14:54:27 UTC) #6
mikio
On Thu, Jul 25, 2013 at 11:54 PM, Dave Cheney <dave@cheney.net> wrote: > Thanks for ...
10 years, 8 months ago (2013-07-25 15:00:49 UTC) #7
dfc
Yup. I'm ashamed to admit I proposed something very icky using types nils. On 26/07/2013, ...
10 years, 8 months ago (2013-07-25 15:26:39 UTC) #8
dfc
I am having difficulty reviewing this change as I cannot determine a theme. Can you ...
10 years, 8 months ago (2013-07-28 02:37:44 UTC) #9
mikio
On Sun, Jul 28, 2013 at 11:37 AM, <dave@cheney.net> wrote: > I am having difficulty ...
10 years, 8 months ago (2013-07-28 02:50:53 UTC) #10
dfc
Can't you do the socketaddr interface move and the other move without changing their contents ...
10 years, 8 months ago (2013-07-28 03:10:17 UTC) #11
mikio
On Sun, Jul 28, 2013 at 12:10 PM, Dave Cheney <dave@cheney.net> wrote: > Can't you ...
10 years, 8 months ago (2013-07-28 03:22:45 UTC) #12
dfc
Or, is it possible to refractor those methods in place, the propose a follow up ...
10 years, 8 months ago (2013-07-28 03:32:26 UTC) #13
rsc
https://codereview.appspot.com/8726051/diff/140001/src/pkg/net/iprawsock_posix.go File src/pkg/net/iprawsock_posix.go (right): https://codereview.appspot.com/8726051/diff/140001/src/pkg/net/iprawsock_posix.go#newcode185 src/pkg/net/iprawsock_posix.go:185: fd, err := socket(family, syscall.SOCK_RAW, proto, ipv6only, net, func(fd ...
10 years, 7 months ago (2013-08-16 01:21:51 UTC) #14
mikio
On Friday, August 16, 2013 10:21:51 AM UTC+9, rsc wrote: Usually refactor means things get ...
10 years, 7 months ago (2013-08-16 04:26:50 UTC) #15
rsc
The old code was fd, err := internetSocket(net, laddr, raddr, deadline, syscall.SOCK_RAW, proto, "dial", sockaddrToIP) ...
10 years, 7 months ago (2013-08-16 05:40:03 UTC) #16
mikio
Thanks. Leave it as it is for now and will revisit when someone wants to ...
10 years, 7 months ago (2013-08-18 10:30:47 UTC) #17
mikio
10 years, 7 months ago (2013-08-18 10:31:08 UTC) #18
*** Abandoned ***
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b