Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(282)

Issue 8716043: Make AddServiceUnits API call return unit names

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years, 7 months ago by frankban
Modified:
8 years, 7 months ago
Reviewers:
dimitern, mp+158670, rog
Visibility:
Public.

Description

Make AddServiceUnits API call return unit names Updated the AddServiceUnits API call so that it returns the names of newly created units, as required by the Juju GUI. https://code.launchpad.net/~frankban/juju-core/bug-1168386-unit-names/+merge/158670 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 11

Patch Set 2 : Make AddServiceUnits API call return unit names #

Patch Set 3 : Make AddServiceUnits API call return unit names #

Unified diffs Side-by-side diffs Delta from patch set Stats (+94 lines, -70 lines) Patch
A [revision details] View 1 1 chunk +2 lines, -0 lines 0 comments Download
M cmd/juju/addunit.go View 1 chunk +2 lines, -1 line 0 comments Download
M state/api/apiclient.go View 1 12 chunks +33 lines, -59 lines 0 comments Download
M state/api/params/params.go View 1 chunk +6 lines, -0 lines 0 comments Download
M state/apiserver/api_test.go View 1 2 chunks +31 lines, -1 line 0 comments Download
M state/apiserver/apiserver.go View 1 1 chunk +10 lines, -2 lines 0 comments Download
M state/statecmd/addunit.go View 1 chunk +5 lines, -6 lines 0 comments Download
M state/statecmd/addunit_test.go View 1 2 chunks +5 lines, -1 line 0 comments Download

Messages

Total messages: 7
frankban
Please take a look.
8 years, 7 months ago (2013-04-12 16:24:12 UTC) #1
rog
LGTM with a few trivial remarks below addressed. thanks! https://codereview.appspot.com/8716043/diff/1/state/api/apiclient.go File state/api/apiclient.go (right): https://codereview.appspot.com/8716043/diff/1/state/api/apiclient.go#newcode153 state/api/apiclient.go:153: ...
8 years, 7 months ago (2013-04-12 17:37:18 UTC) #2
dimitern
LGTM with roger's suggestions, and one of mine. https://codereview.appspot.com/8716043/diff/1/state/api/apiclient.go File state/api/apiclient.go (right): https://codereview.appspot.com/8716043/diff/1/state/api/apiclient.go#newcode153 state/api/apiclient.go:153: err ...
8 years, 7 months ago (2013-04-12 18:01:09 UTC) #3
frankban
Please take a look. https://codereview.appspot.com/8716043/diff/1/state/api/apiclient.go File state/api/apiclient.go (right): https://codereview.appspot.com/8716043/diff/1/state/api/apiclient.go#newcode153 state/api/apiclient.go:153: err := c.st.client.Call("Client", "", "AddServiceUnits", ...
8 years, 7 months ago (2013-04-15 09:54:02 UTC) #4
rog
LGTM On 2013/04/15 09:54:02, frankban wrote: > Please take a look. > > https://codereview.appspot.com/8716043/diff/1/state/api/apiclient.go > ...
8 years, 7 months ago (2013-04-15 09:58:37 UTC) #5
frankban
*** Submitted: Make AddServiceUnits API call return unit names Updated the AddServiceUnits API call so ...
8 years, 7 months ago (2013-04-15 10:01:34 UTC) #6
frankban
8 years, 7 months ago (2013-04-15 10:02:33 UTC) #7
Thanks for your reviews Roger and Dimiter!
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b