Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(3438)

Issue 8711043: A simple Makefile. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 11 months ago by jtv.canonical
Modified:
10 years, 7 months ago
Reviewers:
mp+158640, dimitern, wallyworld, julian.edwards
Visibility:
Public.

Description

A simple Makefile. This is meant to make life a bit better in several ways: 1. Convenient shorthand for various "go" commands. In particular, "make" is a quick way to test for build breakage. 2. Hiding the details of what those "go" commands are (e.g. "go fmt" does not accept gofmt's -s option on my system, so different command line needed). 3. Codifying what the right commands are, and the assumption that a working branch lives inside $GOPATH. 4. Producing recognizable failure output after a failed test suite, since any errors may have scrolled out of view and "go test" does not print a test summary at the end. Some have said they probably won't be using this. That's fine. For those who do, I hope this will make life a bit easier with shorter commands, tab completion etc. https://code.launchpad.net/~jtv/juju-core/makefile/+merge/158640 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 2

Patch Set 2 : A simple Makefile. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -0 lines) Patch
A Makefile View 1 1 chunk +21 lines, -0 lines 0 comments Download
A [revision details] View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 16
jtv.canonical
Please take a look.
10 years, 11 months ago (2013-04-12 15:14:09 UTC) #1
dfc
One comment. I am so not kicking over this hornets nest today. https://codereview.appspot.com/8711043/diff/1/Makefile File Makefile ...
10 years, 11 months ago (2013-04-12 23:38:56 UTC) #2
dimitern
NOT LGTM, as I don't think this is useful.
10 years, 11 months ago (2013-04-18 08:39:13 UTC) #3
jtv.canonical
On 2013/04/18 08:39:13, dimitern wrote: > NOT LGTM, as I don't think this is useful. ...
10 years, 11 months ago (2013-04-19 00:26:17 UTC) #4
dfc
> Does anybody have any actual solutions for these problems instead of > saying that ...
10 years, 11 months ago (2013-04-19 00:30:33 UTC) #5
julian.edwards
I am extremely disappointed with the response to Jeroen's work on this branch. He has ...
10 years, 11 months ago (2013-04-19 00:51:08 UTC) #6
gavinpanella
https://codereview.appspot.com/8711043/diff/1/Makefile File Makefile (right): https://codereview.appspot.com/8711043/diff/1/Makefile#newcode6 Makefile:6: go build $(PROJECT)/... The $(PROJECT)/... bit limits the usefulness ...
10 years, 11 months ago (2013-04-19 09:22:38 UTC) #7
dfc
> The $(PROJECT)/... bit limits the usefulness of this Makefile to only > the branch ...
10 years, 11 months ago (2013-04-19 09:24:38 UTC) #8
gavinpanella
On 2013/04/19 09:24:38, dfc wrote: > You sort of have to use $GOPATH, it's not ...
10 years, 11 months ago (2013-04-19 09:45:22 UTC) #9
dfc
They work for you because you use relative locations, this is a degenerate use of ...
10 years, 11 months ago (2013-04-19 09:47:23 UTC) #10
jtv.canonical
Actually what Gavin brings up here is another one of the things I was hoping ...
10 years, 11 months ago (2013-04-19 11:55:02 UTC) #11
wallyworld
LGTM with Gavin's suggestions Thanks for doing this, I think it will be nice to ...
10 years, 11 months ago (2013-04-19 13:07:08 UTC) #12
wallyworld
On 2013/04/19 13:07:08, wallyworld wrote: > LGTM with Gavin's suggestions > Thanks for doing this, ...
10 years, 11 months ago (2013-04-19 13:08:24 UTC) #13
niemeyer
On 2013/04/19 00:51:08, julian.edwards wrote: > I am extremely disappointed with the response to Jeroen's ...
10 years, 11 months ago (2013-04-19 18:10:05 UTC) #14
julian.edwards
LGTM Thank you for your branch jtv, I will find it useful.
10 years, 11 months ago (2013-04-21 23:22:57 UTC) #15
jtv.canonical
10 years, 11 months ago (2013-04-24 07:17:31 UTC) #16
*** Submitted:

A simple Makefile.

This is meant to make life a bit better in several ways:

1. Convenient shorthand for various "go" commands.  In particular, "make" is a
quick way to test for build breakage.

2. Hiding the details of what those "go" commands are (e.g. "go fmt" does not
accept gofmt's -s option on my system, so different command line needed).

3. Codifying what the right commands are, and the assumption that a working
branch lives inside $GOPATH.

4. Producing recognizable failure output after a failed test suite, since any
errors may have scrolled out of view and "go test" does not print a test summary
at the end.

Some have said they probably won't be using this.  That's fine.  For those who
do, I hope this will make life a bit easier with shorter commands, tab
completion etc.

R=dfc, dimitern, julian.edwards, gavinpanella, wallyworld, niemeyer
CC=
https://codereview.appspot.com/8711043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b