Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(5905)

Issue 8707043: Style the browser changelog list.

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 7 months ago by rharding
Modified:
11 years, 7 months ago
Reviewers:
mp+158597, j.c.sackett
Visibility:
Public.

Description

Style the browser changelog list. - Fix the test that mocks out the callback to use ev.halt() https://code.launchpad.net/~rharding/juju-gui/changelog-design/+merge/158597 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Style the browser changelog list. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+104 lines, -43 lines) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M app/subapps/browser/templates/browser_charm.handlebars View 2 chunks +46 lines, -25 lines 0 comments Download
M app/subapps/browser/views/charm.js View 3 chunks +11 lines, -8 lines 0 comments Download
M lib/views/browser/charm-full.less View 1 chunk +27 lines, -0 lines 0 comments Download
M lib/views/browser/section-title.less View 1 chunk +11 lines, -5 lines 0 comments Download
M test/test_browser_charm_details.js View 3 chunks +7 lines, -5 lines 0 comments Download

Messages

Total messages: 4
rharding
Please take a look.
11 years, 7 months ago (2013-04-12 12:42:19 UTC) #1
j.c.sackett
LGTM. Thanks.
11 years, 7 months ago (2013-04-12 12:51:05 UTC) #2
rharding
LGTM
11 years, 7 months ago (2013-04-12 13:00:17 UTC) #3
rharding
11 years, 7 months ago (2013-04-12 13:03:54 UTC) #4
*** Submitted:

Style the browser changelog list.

- Fix the test that mocks out the callback to use ev.halt()

R=j.c.sackett
CC=
https://codereview.appspot.com/8707043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b