Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(656)

Issue 8706043: Implement add_unit in GoEnvironment.

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years, 7 months ago by frankban
Modified:
8 years, 7 months ago
Reviewers:
benji, gary.poster, mp+158573
Visibility:
Public.

Description

Implement add_unit in GoEnvironment. https://code.launchpad.net/~frankban/juju-gui/bug-1168308-add-unit/+merge/158573 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 2

Patch Set 2 : Implement add_unit in GoEnvironment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+102 lines, -0 lines) Patch
A [revision details] View 1 1 chunk +2 lines, -0 lines 0 comments Download
M app/store/env/go.js View 1 1 chunk +59 lines, -0 lines 0 comments Download
M test/test_env_go.js View 1 chunk +41 lines, -0 lines 0 comments Download

Messages

Total messages: 5
frankban
Please take a look.
8 years, 7 months ago (2013-04-12 11:50:36 UTC) #1
gary.poster
LGTM. Thank you for doing this, and especially for finding the need. https://codereview.appspot.com/8706043/diff/1/app/store/env/go.js File app/store/env/go.js ...
8 years, 7 months ago (2013-04-12 12:13:26 UTC) #2
benji
LGTM
8 years, 7 months ago (2013-04-12 14:17:18 UTC) #3
frankban
*** Submitted: Implement add_unit in GoEnvironment. R=gary.poster, benji CC= https://codereview.appspot.com/8706043 https://codereview.appspot.com/8706043/diff/1/app/store/env/go.js File app/store/env/go.js (right): https://codereview.appspot.com/8706043/diff/1/app/store/env/go.js#newcode403 ...
8 years, 7 months ago (2013-04-12 14:49:42 UTC) #4
frankban
8 years, 7 months ago (2013-04-12 14:54:33 UTC) #5
Hi Gary and Benji, thanks for the reviews.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b