Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1)

Issue 87020044: code review 87020044: cmd/prof, libmach: delete (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 1 month ago by rsc
Modified:
11 years, 1 month ago
Reviewers:
minux1, gobot
CC:
golang-codereviews, minux1, iant, r
Visibility:
Public.

Description

cmd/prof, libmach: delete We have never released cmd/prof and don't plan to. Now that nm, addr2line, and objdump have been rewritten in Go, cmd/prof is the only thing keeping us from deleting libmach. Delete cmd/prof, and then since nothing is using libmach, delete libmach. 13,000 lines of C deleted.

Patch Set 1 #

Patch Set 2 : diff -r 77578375f623 https://code.google.com/p/go/ #

Patch Set 3 : diff -r 77578375f623 https://code.google.com/p/go/ #

Patch Set 4 : diff -r 3a412db5d515 https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -13047 lines) Patch
R include/bootexec.h View 1 1 chunk +0 lines, -169 lines 0 comments Download
R include/mach.h View 1 1 chunk +0 lines, -411 lines 0 comments Download
R include/plan9/mach.h View 1 1 chunk +0 lines, -5 lines 0 comments Download
R include/plan9/ureg_amd64.h View 1 1 chunk +0 lines, -5 lines 0 comments Download
R include/plan9/ureg_arm.h View 1 1 chunk +0 lines, -5 lines 0 comments Download
R include/plan9/ureg_x86.h View 1 1 chunk +0 lines, -5 lines 0 comments Download
R include/ureg_amd64.h View 1 1 chunk +0 lines, -59 lines 0 comments Download
R include/ureg_arm.h View 1 1 chunk +0 lines, -50 lines 0 comments Download
R include/ureg_x86.h View 1 1 chunk +0 lines, -54 lines 0 comments Download
M src/cmd/dist/build.c View 1 2 3 7 chunks +0 lines, -29 lines 0 comments Download
R src/cmd/prof/Makefile View 1 1 chunk +0 lines, -5 lines 0 comments Download
R src/cmd/prof/doc.go View 1 1 chunk +0 lines, -49 lines 0 comments Download
R src/cmd/prof/main.c View 1 1 chunk +0 lines, -905 lines 0 comments Download
R src/libmach/5.c View 1 1 chunk +0 lines, -92 lines 0 comments Download
R src/libmach/5db.c View 1 1 chunk +0 lines, -1093 lines 0 comments Download
R src/libmach/6.c View 1 1 chunk +0 lines, -145 lines 0 comments Download
R src/libmach/8.c View 1 1 chunk +0 lines, -108 lines 0 comments Download
R src/libmach/8db.c View 1 1 chunk +0 lines, -2443 lines 0 comments Download
R src/libmach/Makefile View 1 1 chunk +0 lines, -5 lines 0 comments Download
R src/libmach/access.c View 1 1 chunk +0 lines, -241 lines 0 comments Download
R src/libmach/darwin.c View 1 1 chunk +0 lines, -890 lines 0 comments Download
R src/libmach/dragonfly.c View 1 1 chunk +0 lines, -62 lines 0 comments Download
R src/libmach/elf.h View 1 1 chunk +0 lines, -182 lines 0 comments Download
R src/libmach/executable.c View 1 1 chunk +0 lines, -1525 lines 0 comments Download
R src/libmach/fakeobj.c View 1 1 chunk +0 lines, -29 lines 0 comments Download
R src/libmach/freebsd.c View 1 1 chunk +0 lines, -62 lines 0 comments Download
R src/libmach/linux.c View 1 1 chunk +0 lines, -1008 lines 0 comments Download
R src/libmach/machdata.c View 1 1 chunk +0 lines, -477 lines 0 comments Download
R src/libmach/macho.h View 1 1 chunk +0 lines, -100 lines 0 comments Download
R src/libmach/map.c View 1 1 chunk +0 lines, -183 lines 0 comments Download
R src/libmach/netbsd.c View 1 1 chunk +0 lines, -56 lines 0 comments Download
R src/libmach/obj.h View 1 1 chunk +0 lines, -53 lines 0 comments Download
R src/libmach/obj.c View 1 1 chunk +0 lines, -77 lines 0 comments Download
R src/libmach/openbsd.c View 1 1 chunk +0 lines, -56 lines 0 comments Download
R src/libmach/plan9.c View 1 1 chunk +0 lines, -72 lines 0 comments Download
R src/libmach/setmach.c View 1 1 chunk +0 lines, -203 lines 0 comments Download
R src/libmach/solaris.c View 1 1 chunk +0 lines, -56 lines 0 comments Download
R src/libmach/swap.c View 1 1 chunk +0 lines, -107 lines 0 comments Download
R src/libmach/sym.c View 1 1 chunk +0 lines, -1884 lines 0 comments Download
R src/libmach/windows.c View 1 1 chunk +0 lines, -87 lines 0 comments Download

Messages

Total messages: 4
rsc
Hello golang-codereviews@googlegroups.com (cc: iant, r), I'd like you to review this change to https://code.google.com/p/go/
11 years, 1 month ago (2014-04-14 14:03:57 UTC) #1
minux1
Aha, didn't see this one before comment on the objdump CL. LGTM. No more stubs ...
11 years, 1 month ago (2014-04-14 14:21:21 UTC) #2
rsc
*** Submitted as https://code.google.com/p/go/source/detail?r=9d94bbf68821 *** cmd/prof, libmach: delete We have never released cmd/prof and don't ...
11 years, 1 month ago (2014-04-14 15:09:27 UTC) #3
gobot
11 years, 1 month ago (2014-04-14 16:01:06 UTC) #4
Message was sent while issue was closed.
This CL appears to have broken the linux-386-387 builder.
See http://build.golang.org/log/537b1c383c6f87cd762367b7c5db9327b9b8f4ad
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b