Issue 8701045: Ignore pending services' endpoints

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 8701045: Ignore pending services' endpoints

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 5 months ago by matthew.scott

Modified:
11 years, 5 months ago

Reviewers:
frankban, mp+159718, jeff.pihach

Visibility:
Public.

Description

Ignore pending services' endpoints Previously, creating a relation while a service was in pending (ghost) status caused errors. This removes pending services from consideration when gathering endpoints. https://code.launchpad.net/~makyo/juju-gui/ghost-rels-1170304/+merge/159718 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Ignore pending services' endpoints #

Total comments: 3

Patch Set 3 : Ignore pending services' endpoints #

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+26 lines, -3 lines)			Patch
A	[revision details]	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
M	app/models/endpoints.js	View	1 2	1 chunk	+6 lines, -2 lines	0 comments	Download
M	app/views/topology/relation.js	View	1 2	1 chunk	+7 lines, -1 line	0 comments	Download
M	test/test_endpoints.js	View		1 chunk	+11 lines, -0 lines	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

jeff.pihach

LGTM Thanks, Just a few trivial documentation requests, do with them what you will :) ...

11 years, 5 months ago (2013-04-19 01:48:18 UTC) #4

frankban

Thank you Matthew, the branch works well. LGTM! https://codereview.appspot.com/8701045/diff/4001/app/models/endpoints.js File app/models/endpoints.js (right): https://codereview.appspot.com/8701045/diff/4001/app/models/endpoints.js#newcode96 app/models/endpoints.js:96: Y.each(db.services.filter(function(endpoint) ...

11 years, 5 months ago (2013-04-19 08:30:39 UTC) #5

matthew.scott

11 years, 5 months ago (2013-04-19 14:32:10 UTC) #6

*** Submitted:

Ignore pending services' endpoints

Previously, creating a relation while a service was in pending (ghost) status
caused errors.  This removes pending services from consideration when gathering
endpoints.

R=jeff.pihach, frankban
CC=
https://codereview.appspot.com/8701045

Expand All Messages | Collapse All Messages