Issue 8695051: code review 8695051: undo CL 8954044 / ad3c2ffb16d7

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 8695051: code review 8695051: undo CL 8954044 / ad3c2ffb16d7 (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years ago by atom

Modified:
12 years ago

Reviewers:

CC:
golang-dev, r

Visibility:
Public.

Description

undo CL 8954044 / ad3c2ffb16d7 It works on i386, but fails on amd64 and arm. ««« original CL description runtime: prevent the GC from seeing the content of a frame in runfinq() Fixes issue 5348. R=golang-dev, dvyukov CC=golang-dev https://codereview.appspot.com/8954044 »»»

Patch Set 1 #

Patch Set 2 : diff -r ad3c2ffb16d7 https://code.google.com/p/go/ #

Patch Set 3 : diff -r ad3c2ffb16d7 https://code.google.com/p/go/ #

Patch Set 4 : diff -r ad3c2ffb16d7 https://code.google.com/p/go/ #

Created: 12 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -38 lines)			Patch
	M	src/pkg/runtime/mgc0.c	View	1	1 chunk	+1 line, -1 line	0 comments	Download
	R	test/fixedbugs/issue5348.go	View	1	1 chunk	+0 lines, -37 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

atom

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/

12 years ago (2013-04-25 15:21:55 UTC) #1

atom

12 years ago (2013-04-25 16:12:15 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=16aa97d39879 ***

undo CL 8954044 / ad3c2ffb16d7

It works on i386, but fails on amd64 and arm.

««« original CL description
runtime: prevent the GC from seeing the content of a frame in runfinq()

Fixes issue 5348.

R=golang-dev, dvyukov
CC=golang-dev
https://codereview.appspot.com/8954044
»»»

R=golang-dev, r
CC=golang-dev
https://codereview.appspot.com/8695051

Expand All Messages | Collapse All Messages