Issue 86910043: uniter: hook up manifest deployer

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 86910043: uniter: hook up manifest deployer

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years ago by fwereade

Modified:
10 years ago

Reviewers:
jameinel, mp+215460

Visibility:
Public.

Description

uniter: hook up manifest deployer New unit agents use a manifest deployer from the start. Pre-existing ones use their git deployer only for long enough to recover from charm conflicts, and use a manifest deployer for all subsequent upgrades. The .git directory in the charm dir will persist until the next charm upgrade completes, but can be safely removed at any time after the deployer is changed. https://code.launchpad.net/~fwereade/juju-core/manifest-charm-deployer/+merge/215460 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 2

Created: 10 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+877 lines, -162 lines)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	worker/uniter/charm/charm_test.go	View	2 chunks	+12 lines, -2 lines	0 comments	Download
A	worker/uniter/charm/converter.go	View	1 chunk	+152 lines, -0 lines	0 comments	Download
A	worker/uniter/charm/converter_test.go	View	1 chunk	+130 lines, -0 lines	2 comments	Download
M	worker/uniter/charm/export_test.go	View	1 chunk	+10 lines, -0 lines	0 comments	Download
M	worker/uniter/charm/manifest_deployer.go	View	2 chunks	+1 line, -1 line	0 comments	Download
M	worker/uniter/charm/manifest_deployer_test.go	View	3 chunks	+3 lines, -9 lines	0 comments	Download
M	worker/uniter/modes.go	View	4 chunks	+19 lines, -5 lines	0 comments	Download
M	worker/uniter/uniter.go	View	6 chunks	+20 lines, -7 lines	0 comments	Download
A	worker/uniter/uniter_old_test.go	View	1 chunk	+226 lines, -0 lines	0 comments	Download
M	worker/uniter/uniter_test.go	View	21 chunks	+302 lines, -138 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

jameinel

I really enjoyed reviewing this, I wish you posted more code for us to review. ...

10 years ago (2014-04-16 10:36:16 UTC) #2

fwereade

10 years ago (2014-04-18 08:05:50 UTC) #3

Thanks :).

https://codereview.appspot.com/86910043/diff/1/worker/uniter/charm/converter_...
File worker/uniter/charm/converter_test.go (right):

https://codereview.appspot.com/86910043/diff/1/worker/uniter/charm/converter_...
worker/uniter/charm/converter_test.go:128: ft.File{"common", "final",
0644}.Check(c, s.targetPath)
On 2014/04/16 10:36:16, jameinel wrote:
> You don't seem to check what the status of "user" is here.

preserveUser.Check(...)?

Expand All Messages | Collapse All Messages