Issue 869047: Resolve null pointer issue in DefaultJsUriManager.java

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 869047: Resolve null pointer issue in DefaultJsUriManager.java

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years ago by zhoresh

Modified:
14 years ago

Reviewers:
johnfargo, Paul Lindner, shindig.remailer

Base URL:
http://svn.apache.org/repos/asf/shindig/trunk/

Visibility:
Public.

Description

DefaultJsUriManager should use the uri in the gadget context instead of the gadget spec, since it can be used without spec defined.

Patch Set 2 : I forgot to include updated tests (JsUriManager does not use gadget.spec anymore) #

Created: 14 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -25 lines)			Patch
		java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/DefaultJsUriManager.java	View		2 chunks	+5 lines, -6 lines	0 comments	Download
		java/gadgets/src/test/java/org/apache/shindig/gadgets/uri/DefaultJsUriManagerTest.java	View		2 chunks	+6 lines, -19 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Paul Lindner

I get test failures with this patch: Failed tests: makeJsUriAddPathSlashVersioned(org.apache.shindig.gadgets.uri.DefaultJsUriManagerTest) makeAndProcessSymmetric(org.apache.shindig.gadgets.uri.DefaultJsUriManagerTest)

14 years ago (2010-04-13 07:38:33 UTC) #2

zhoresh

I forgot to include updated tests (JsUriManager does not use gadget.spec anymore)

14 years ago (2010-04-13 17:01:30 UTC) #3

Paul Lindner

14 years ago (2010-04-13 17:30:48 UTC) #4

Thanks!

patch applied.


On Tue, Apr 13, 2010 at 10:01 AM, <zhoresh@gmail.com> wrote:

> I forgot to include updated tests (JsUriManager does not use gadget.spec
> anymore)
>
> http://codereview.appspot.com/869047/show
>

Expand All Messages | Collapse All Messages