Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1005)

Issue 8686048: Add a Makefile npm-cache target to upload to LP

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 7 months ago by benji
Modified:
9 years, 7 months ago
Reviewers:
rharding, mp+161479, gary.poster
Visibility:
Public.

Description

Add a Makefile npm-cache target to upload to LP There is a parallel charm branch that uses the cache file to speed deploying of branch builds. https://code.launchpad.net/~benji/juju-gui/npm-cache/+merge/161479 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 6

Patch Set 2 : Add a Makefile npm-cache target to upload to LP #

Patch Set 3 : Add a Makefile npm-cache target to upload to LP #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -4 lines) Patch
M Makefile View 1 4 chunks +49 lines, -4 lines 0 comments Download
A [revision details] View 1 1 chunk +2 lines, -0 lines 0 comments Download
M docs/process.rst View 1 chunk +20 lines, -0 lines 0 comments Download

Messages

Total messages: 6
benji
Please take a look.
9 years, 7 months ago (2013-04-29 19:09:01 UTC) #1
rharding
LGTM very cool use of make to push updates to the cache.
9 years, 7 months ago (2013-04-29 19:15:13 UTC) #2
gary.poster
LGTM with responses--changes preferred, but I'm open to counterarguments instead--to comments. Thank you! This is ...
9 years, 7 months ago (2013-04-29 20:18:34 UTC) #3
benji
Good points. I haven't taken action yet, pending discussion. https://codereview.appspot.com/8686048/diff/1/Makefile File Makefile (right): https://codereview.appspot.com/8686048/diff/1/Makefile#newcode98 Makefile:98: ...
9 years, 7 months ago (2013-04-29 20:38:49 UTC) #4
benji
Please take a look.
9 years, 7 months ago (2013-04-30 14:58:47 UTC) #5
benji
9 years, 7 months ago (2013-04-30 15:27:25 UTC) #6
*** Submitted:

Add a Makefile npm-cache target to upload to LP

There is a parallel charm branch that uses the cache file to speed deploying
of branch builds.

R=rharding, gary.poster
CC=
https://codereview.appspot.com/8686048
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b