Issue 8664047: state/(presence, log): less logging

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 8664047: state/(presence, log): less logging

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years ago by rog

Modified:
11 years ago

Reviewers:
mp+159175, fwereade

Visibility:
Public.

Description

state/(presence, log): less logging https://code.launchpad.net/~rogpeppe/juju-core/287-blessed-silence/+merge/159175 (do not edit description out of merge proposal)

Patch Set 2 : state/(presence, log): less logging #

Total comments: 4

Patch Set 3 : state/(presence, log): less logging #

Created: 11 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+36 lines, -14 lines)			Patch
A	[revision details]	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
M	state/presence/presence.go	View		10 chunks	+20 lines, -9 lines	0 comments	Download
M	state/watcher/watcher.go	View	1 2	6 chunks	+14 lines, -5 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

fwereade

LGTM with quibbles https://codereview.appspot.com/8664047/diff/2001/state/watcher/watcher.go File state/watcher/watcher.go (left): https://codereview.appspot.com/8664047/diff/2001/state/watcher/watcher.go#oldcode278 state/watcher/watcher.go:278: log.Debugf("state/watcher: got request: %#v", req) I'd ...

11 years ago (2013-04-16 15:17:11 UTC) #2

rog

11 years ago (2013-04-16 15:27:56 UTC) #3

*** Submitted:

state/(presence, log): less logging

R=fwereade
CC=
https://codereview.appspot.com/8664047

https://codereview.appspot.com/8664047/diff/2001/state/watcher/watcher.go
File state/watcher/watcher.go (left):

https://codereview.appspot.com/8664047/diff/2001/state/watcher/watcher.go#old...
state/watcher/watcher.go:278: log.Debugf("state/watcher: got request: %#v", req)
On 2013/04/16 15:17:11, fwereade wrote:
> I'd prefer to keep all the spam for when we have the spam, please.

this is quite recent - probably a debugging remnant and
not worth keeping IMHO, but added back anyway.

https://codereview.appspot.com/8664047/diff/2001/state/watcher/watcher.go
File state/watcher/watcher.go (right):

https://codereview.appspot.com/8664047/diff/2001/state/watcher/watcher.go#new...
state/watcher/watcher.go:375: if Debug {
On 2013/04/16 15:17:11, fwereade wrote:
> ?

Done.

Expand All Messages | Collapse All Messages