Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(16155)

Issue 8663043: Fix sandbox setconfig and associated test

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years ago by gary.poster
Modified:
11 years ago
Reviewers:
bac, matthew.scott, mp+158380
Visibility:
Public.

Description

Fix sandbox setconfig and associated test The sandbox setconfig test was taking over a second--a pretty clear indication that it was waiting on the fake delta stream rather than a direct response. Investigation revealed that the sandbox method was incorrectly using the ASYNCOP helper rather than the OP helper. This small branch fixes the setconfig problem and adjusts the tests. The test is very fast now (not yellow or red in the mocha output). https://code.launchpad.net/~gary/juju-gui/setconfigfix/+merge/158380 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Fix sandbox setconfig and associated test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M app/store/env/sandbox.js View 1 chunk +1 line, -1 line 0 comments Download
M test/test_sandbox.js View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 5
gary.poster
Please take a look.
11 years ago (2013-04-11 14:03:44 UTC) #1
bac
LGTM. Thanks.
11 years ago (2013-04-11 14:14:46 UTC) #2
matthew.scott
LGTM, thanks for the fix.
11 years ago (2013-04-11 14:50:29 UTC) #3
gary.poster
*** Submitted: Fix sandbox setconfig and associated test The sandbox setconfig test was taking over ...
11 years ago (2013-04-11 15:37:34 UTC) #4
gary.poster
11 years ago (2013-04-11 15:38:28 UTC) #5
Thank you both.

Gary
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b