code review 8661045: go.crypto/ssh/test: Replace FailNow with Fail where it ...

go.crypto/ssh/test: Replace FailNow with Fail where it is obvious that the test doesn't want to fail now.

Improve a couple of test error messages too.

[dsymonds, 2013-04-18 03:18:10]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go.crypto

[bradfitz, 2013-04-22 18:28:55]

LGTM



On Wed, Apr 17, 2013 at 8:18 PM, <dsymonds@golang.org> wrote:

> Reviewers: golang-dev1,
>
> Message:
> Hello golang-dev@googlegroups.com,
>
> I'd like you to review this change to
> https://code.google.com/p/go.**crypto<https://code.google.com/p/go.crypto>
>
>
> Description:
> go.crypto/ssh/test: Replace FailNow with Fail where it is obvious that
> the test doesn't want to fail now.
>
> Improve a couple of test error messages too.
>
> Please review this at
https://codereview.appspot.**com/8661045/<https://codereview.appspot.com/8661...
>
> Affected files:
>   M ssh/test/test_unix_test.go
>
>
> Index: ssh/test/test_unix_test.go
> ==============================**==============================**=======
> --- a/ssh/test/test_unix_test.go
> +++ b/ssh/test/test_unix_test.go
> @@ -114,15 +114,15 @@
>         s.cmd.Stderr = os.Stderr // &s.output
>         err = s.cmd.Start()
>         if err != nil {
> -               s.t.FailNow()
> +               s.t.Fail()
>                 s.Shutdown()
> -               s.t.Fatal(err)
> +               s.t.Fatalf("s.cmd.Start: %v", err)
>         }
>         conn, err := ssh.Client(&client{stdin, stdout}, config)
>         if err != nil {
> -               s.t.FailNow()
> +               s.t.Fail()
>                 s.Shutdown()
> -               s.t.Fatal(err)
> +               s.t.Fatalf("ssh.Client: %v", err)
>         }
>         return conn
>  }
>
>
> --
>
> ---You received this message because you are subscribed to the Google
> Groups "golang-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to
golang-dev+unsubscribe@**googlegroups.com<golang-dev%2Bunsubscribe@googlegrou...
> .
> For more options, visit
https://groups.google.com/**groups/opt_out<https://groups.google.com/groups/o...
> .
>
>
>

[dsymonds, 2013-04-23 02:15:44]

*** Submitted as
https://code.google.com/p/go/source/detail?r=74277e9c095c&repo=crypto ***

go.crypto/ssh/test: Replace FailNow with Fail where it is obvious that the test
doesn't want to fail now.

Improve a couple of test error messages too.

R=golang-dev, bradfitz
CC=golang-dev
https://codereview.appspot.com/8661045