code review 8660046: net/http/cookiejar: mention go.net/publicsuffix.

net/http/cookiejar: mention go.net/publicsuffix.

[minux1, 2013-04-14 18:35:52]

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go/

[r, 2013-04-14 18:52:32]

https://codereview.appspot.com/8660046/diff/4001/src/pkg/net/http/cookiejar/j...
File src/pkg/net/http/cookiejar/jar.go (right):

https://codereview.appspot.com/8660046/diff/4001/src/pkg/net/http/cookiejar/j...
src/pkg/net/http/cookiejar/jar.go:33: // sub-repository, see
http://godoc.org/code.google.com/p/go.net/publicsuffix.
not sure it's right to put a link to godoc.org here. that's precedent setting.

how about just the package path.

sub-repository, "code.google.com/p/go.net/publicsuffix".

[gburd, 2013-04-14 22:22:32]

https://codereview.appspot.com/8660046/diff/4001/src/pkg/net/http/cookiejar/j...
File src/pkg/net/http/cookiejar/jar.go (right):

https://codereview.appspot.com/8660046/diff/4001/src/pkg/net/http/cookiejar/j...
src/pkg/net/http/cookiejar/jar.go:33: // sub-repository, see
http://godoc.org/code.google.com/p/go.net/publicsuffix.
How about:

An experimental public suffix list implementation is in the package
code.google.com/p/go.net/publicsuffix.

This wording fits the linkify pattern suggested in
https://code.google.com/p/go/issues/detail?id=4953.

[volker.dobler, 2013-04-14 23:12:11]

https://codereview.appspot.com/8660046/diff/4001/src/pkg/net/http/cookiejar/j...
File src/pkg/net/http/cookiejar/jar.go (right):

https://codereview.appspot.com/8660046/diff/4001/src/pkg/net/http/cookiejar/j...
src/pkg/net/http/cookiejar/jar.go:32: // An experimental public suffix list
implementation is in the go.net
Why "experimental"? The package API should be
very stable (maybe some additions in the future).
Only the data might get updated every 2 to 4 weeks.

[minux1, 2013-04-15 07:09:01]

Hello golang-dev@googlegroups.com, r@golang.org, gary.burd@gmail.com,
dr.volker.dobler@gmail.com (cc: golang-dev@googlegroups.com),

Please take another look.

[r, 2013-04-15 17:14:11]

LGTM

[minux1, 2013-04-15 20:30:11]

*** Submitted as https://code.google.com/p/go/source/detail?r=e4f7ec1669aa ***

net/http/cookiejar: mention go.net/publicsuffix.

R=golang-dev, r, gary.burd, dr.volker.dobler
CC=golang-dev
https://codereview.appspot.com/8660046