Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1723)

Issue 8658045: cmd/juju: log when the command finishes

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 7 months ago by rog
Modified:
9 years, 7 months ago
Reviewers:
mp+159197, dimitern, fwereade
Visibility:
Public.

Description

cmd/juju: log when the command finishes Also make sure that machine and unit agents always print the finished error message. https://code.launchpad.net/~rogpeppe/juju-core/288-log-finished/+merge/159197 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : cmd/juju: log when the command finishes #

Total comments: 1

Patch Set 3 : cmd/juju: log when the command finishes #

Total comments: 3

Patch Set 4 : cmd/juju: log when the command finishes #

Patch Set 5 : cmd/juju: log when the command finishes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -6 lines) Patch
A [revision details] View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M cmd/cmd.go View 1 2 2 chunks +0 lines, -2 lines 0 comments Download
M cmd/jujud/machine.go View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M cmd/jujud/unit.go View 1 2 2 chunks +0 lines, -2 lines 0 comments Download
M cmd/supercommand.go View 1 2 2 chunks +8 lines, -1 line 0 comments Download

Messages

Total messages: 7
rog
Please take a look.
9 years, 7 months ago (2013-04-16 16:38:26 UTC) #1
fwereade
https://codereview.appspot.com/8658045/diff/2001/cmd/juju/main.go File cmd/juju/main.go (right): https://codereview.appspot.com/8658045/diff/2001/cmd/juju/main.go#newcode80 cmd/juju/main.go:80: os.Exit(status) Why aren't we doing this at the end ...
9 years, 7 months ago (2013-04-17 12:01:34 UTC) #2
rog
Please take a look.
9 years, 7 months ago (2013-04-18 13:15:39 UTC) #3
fwereade
LGTM trivial
9 years, 7 months ago (2013-04-18 13:16:28 UTC) #4
dimitern
Looks good, although I'm not sure why these two Noticefs were removed. https://codereview.appspot.com/8658045/diff/6001/cmd/jujud/machine.go File cmd/jujud/machine.go ...
9 years, 7 months ago (2013-04-18 13:16:35 UTC) #5
dimitern
after online discussion, LGTM as well.
9 years, 7 months ago (2013-04-18 13:27:02 UTC) #6
rog
9 years, 7 months ago (2013-04-18 13:29:16 UTC) #7
*** Submitted:

cmd/juju: log when the command finishes

Also make sure that machine and unit agents
always print the finished error message.

R=fwereade, dimitern
CC=
https://codereview.appspot.com/8658045
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b