Fix exposed attribute handling in delta stream

Fix exposed attribute handling in delta stream

This branch fixes the service "exposed" and unit "relation_errors"
attributes handling when the delta comes from juju-core.
The _process_delta function allows for overriding those attrs
in the case a delta stream arrives from PyJuju. The juju-core 
handlers, instead, must update model instances with partial changes, 
e.g. when handling annotations. This was the cause of the regression.

Also improved the cleanUpEntityTags helper.

https://code.launchpad.net/~frankban/juju-gui/bug-1167339-exposed/+merge/158331

(do not edit description out of merge proposal)

[frankban, 2013-04-11 11:16:30]

Please take a look.

[teknico, 2013-04-11 13:29:20]

LGTM

[gary.poster, 2013-04-11 13:47:18]

LGTM.  Thank you!

Gary

https://codereview.appspot.com/8657043/diff/1/app/models/handlers.js
File app/models/handlers.js (right):

https://codereview.appspot.com/8657043/diff/1/app/models/handlers.js#newcode239
app/models/handlers.js:239: // We cannot use the process_delta methods here,
because their legacy
So, process_delta is still useful for non-annotation watcher deltas, right? 
Otherwise I'd like to rename the function as legacy (processPyDelta or similar)
for clarity.

[frankban, 2013-04-11 13:52:25]

On 2013/04/11 13:47:18, gary.poster wrote:
> LGTM.  Thank you!
> 
> Gary
> 
> https://codereview.appspot.com/8657043/diff/1/app/models/handlers.js
> File app/models/handlers.js (right):
> 
>
https://codereview.appspot.com/8657043/diff/1/app/models/handlers.js#newcode239
> app/models/handlers.js:239: // We cannot use the process_delta methods here,
> because their legacy
> So, process_delta is still useful for non-annotation watcher deltas, right? 
> Otherwise I'd like to rename the function as legacy (processPyDelta or
similar)
> for clarity.

Yes it is. The process_delta methods (and as a consequence the _process_delta
function) are still used by the other juju-core delta handlers. Anyway, a future
code reorganization, i.e. if we promote the juju-core as our main delta
reference, could lead to some clean up/refactoring/renaming of legacy functions.

Thanks for the reviews!

[frankban, 2013-04-11 13:59:27]

*** Submitted:

Fix exposed attribute handling in delta stream

This branch fixes the service "exposed" and unit "relation_errors"
attributes handling when the delta comes from juju-core.
The _process_delta function allows for overriding those attrs
in the case a delta stream arrives from PyJuju. The juju-core 
handlers, instead, must update model instances with partial changes, 
e.g. when handling annotations. This was the cause of the regression.

Also improved the cleanUpEntityTags helper.

R=teknico, gary.poster
CC=
https://codereview.appspot.com/8657043