Issue 8656044: code review 8656044: net: make deadline helpers join to netFD as its methods

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 8656044: code review 8656044: net: make deadline helpers join to netFD as its methods (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years ago by mikio

Modified:
10 years, 8 months ago

Reviewers:
dvyukov

CC:
golang-dev, dvyukov

Visibility:
Public.

Description

net: make deadline helpers join to netFD as its methods Just for readability reasons; to prevent overlooking deadline stuff across over platforms.

Patch Set 1 : diff -r ebf9b6a68289 https://code.google.com/p/go #

Patch Set 2 : diff -r 0b7a3fb56379 https://code.google.com/p/go #

Created: 10 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+25 lines, -25 lines)			Patch
M	src/pkg/net/fd_plan9.go	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	src/pkg/net/fd_poll_runtime.go	View	1 chunk	+6 lines, -6 lines	0 comments	Download
M	src/pkg/net/fd_poll_unix.go	View	1 chunk	+8 lines, -8 lines	0 comments	Download
M	src/pkg/net/net.go	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	src/pkg/net/sock_posix.go	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/pkg/net/tcpsock_plan9.go	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/net/tcpsock_posix.go	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/net/unixsock_posix.go	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

mikio

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go

10 years, 8 months ago (2013-08-13 10:45:54 UTC) #1

mikio

10 years, 8 months ago (2013-08-13 11:01:05 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=cfa87fec6237 ***

net: make deadline helpers join to netFD as its methods

Just for readability reasons; to prevent overlooking deadline stuff
across over platforms.

R=golang-dev, dvyukov
CC=golang-dev
https://codereview.appspot.com/8656044

Expand All Messages | Collapse All Messages