Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1935)

Issue 8653047: code review 8653047: encoding/xml: allow attributes stored in pointers to be...

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 11 months ago by deemok
Modified:
6 years, 8 months ago
Reviewers:
rsc
CC:
golang-dev, dfc, rsc
Visibility:
Public.

Description

encoding/xml: allow attributes stored in pointers to be marshaled. Fixes issue 5334.

Patch Set 1 #

Patch Set 2 : diff -r dc922c5176b5 https://code.google.com/p/go/ #

Patch Set 3 : diff -r dc922c5176b5 https://code.google.com/p/go/ #

Patch Set 4 : diff -r dc922c5176b5 https://code.google.com/p/go/ #

Total comments: 1

Patch Set 5 : diff -r 6dad366e9f94 https://code.google.com/p/go/ #

Patch Set 6 : diff -r 6dad366e9f94 https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -1 line) Patch
M src/pkg/encoding/xml/marshal.go View 1 2 3 4 5 3 chunks +10 lines, -1 line 0 comments Download
M src/pkg/encoding/xml/marshal_test.go View 1 2 3 4 2 chunks +33 lines, -0 lines 0 comments Download

Messages

Total messages: 11
deemok
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/
6 years, 11 months ago (2013-04-23 04:10:10 UTC) #1
deemok
Sorry, just found out that I made a mistake and will resubmit the patch! Please ...
6 years, 11 months ago (2013-04-23 19:10:18 UTC) #2
deemok
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), Please take another look.
6 years, 11 months ago (2013-04-23 19:24:43 UTC) #3
dfc
On 2013/04/23 19:24:43, deemok wrote: > Hello mailto:golang-dev@googlegroups.com (cc: mailto:golang-dev@googlegroups.com), > > Please take another ...
6 years, 10 months ago (2013-06-01 07:07:12 UTC) #4
rsc
https://codereview.appspot.com/8653047/diff/17001/src/pkg/encoding/xml/marshal.go File src/pkg/encoding/xml/marshal.go (right): https://codereview.appspot.com/8653047/diff/17001/src/pkg/encoding/xml/marshal.go#newcode288 src/pkg/encoding/xml/marshal.go:288: // handle pointer values by following the pointer // ...
6 years, 10 months ago (2013-06-03 20:08:56 UTC) #5
deemok
Hello golang-dev@googlegroups.com, dave@cheney.net, rsc@golang.org (cc: golang-dev@googlegroups.com), Please take another look.
6 years, 10 months ago (2013-06-04 00:40:24 UTC) #6
deemok
Hello golang-dev@googlegroups.com, dave@cheney.net, rsc@golang.org (cc: golang-dev@googlegroups.com), Please take another look.
6 years, 10 months ago (2013-06-04 00:51:52 UTC) #7
rsc
LGTM Apologies for dropping this on the floor.
6 years, 8 months ago (2013-08-08 12:03:51 UTC) #8
rsc
You don't appear to have completed a CLA (golang.org/doc/contribute.html#copyright). Since the change here is so ...
6 years, 8 months ago (2013-08-08 12:06:42 UTC) #9
deemok
Hi, Russ. No worries. I've completed the CLA. Sorry I've not read the contributor's manual ...
6 years, 8 months ago (2013-08-08 13:26:55 UTC) #10
bradfitz
6 years, 8 months ago (2013-08-08 17:41:08 UTC) #11
*** Submitted as https://code.google.com/p/go/source/detail?r=084c06f07a87 ***

encoding/xml: allow attributes stored in pointers to be marshaled.

Fixes issue 5334.

R=golang-dev, dave, rsc
CC=golang-dev
https://codereview.appspot.com/8653047

Committer: Brad Fitzpatrick <bradfitz@golang.org>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b