Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(131)

Side by Side Diff: app/subapps/browser/browser.js

Issue 8651046: Add failing provider notice and fix #1173333
Patch Set: Add failing provider notice and fix #1173333 Created 11 years, 11 months ago
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments. Please Sign in to add in-line comments.
Jump to:
View unified diff | Download patch
« no previous file with comments | « app/models/charm.js ('k') | app/subapps/browser/templates/browser_charm.handlebars » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 'use strict'; 1 'use strict';
2 2
3 3
4 /** 4 /**
5 SubApp for the Browser 5 SubApp for the Browser
6 6
7 @module juju 7 @module juju
8 @submodule subapps 8 @submodule subapps
9 */ 9 */
10 YUI.add('subapp-browser', function(Y) { 10 YUI.add('subapp-browser', function(Y) {
(...skipping 479 matching lines...) Expand 10 before | Expand all | Expand 10 after
490 if (!this._viewState.charmID) { 490 if (!this._viewState.charmID) {
491 this._detailsVisible(false); 491 this._detailsVisible(false);
492 var detailsNode = Y.one('.bws-view-data'); 492 var detailsNode = Y.one('.bws-view-data');
493 if (detailsNode) { 493 if (detailsNode) {
494 detailsNode.hide(); 494 detailsNode.hide();
495 } 495 }
496 // Clean up any details we've got. 496 // Clean up any details we've got.
497 if (this._details) { 497 if (this._details) {
498 this._details.destroy({remove: true}); 498 this._details.destroy({remove: true});
499 } 499 }
500
501 // Update the activeID on the editorial/search results.
502 if (this._editorial) {
503 this._editorial.set('activeID', null);
504 }
505 if (this._search) {
506 this._search.set('activeID', null);
507 }
508
509
510
500 } 511 }
501 512
502 // Sync that the state has changed. 513 // Sync that the state has changed.
503 this._saveState(); 514 this._saveState();
504 next(); 515 next();
505 }, 516 },
506 517
507 /** 518 /**
508 Dispatch to the correct viewmode based on the route that was hit. 519 Dispatch to the correct viewmode based on the route that was hit.
509 520
(...skipping 146 matching lines...) Expand 10 before | Expand all | Expand 10 after
656 'querystring', 667 'querystring',
657 'sub-app', 668 'sub-app',
658 'subapp-browser-charmview', 669 'subapp-browser-charmview',
659 'subapp-browser-editorial', 670 'subapp-browser-editorial',
660 'subapp-browser-fullscreen', 671 'subapp-browser-fullscreen',
661 'subapp-browser-minimized', 672 'subapp-browser-minimized',
662 'subapp-browser-searchview', 673 'subapp-browser-searchview',
663 'subapp-browser-sidebar' 674 'subapp-browser-sidebar'
664 ] 675 ]
665 }); 676 });
OLDNEW
« no previous file with comments | « app/models/charm.js ('k') | app/subapps/browser/templates/browser_charm.handlebars » ('j') | no next file with comments »

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b