Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1236)

Issue 8651046: Add failing provider notice and fix #1173333

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 7 months ago by rharding
Modified:
9 years, 7 months ago
Reviewers:
mp+161267, j.c.sackett
Visibility:
Public.

Description

Add failing provider notice and fix #1173333 - When a provider is known to be failing add a warning container and show the provider icon. - Drive by fix for #1173333 to make sure that we can 'deactive' a selected charm in the editorial and search views. https://code.launchpad.net/~rharding/juju-gui/provider-display/+merge/161267 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Add failing provider notice and fix #1173333 #

Patch Set 3 : Add failing provider notice and fix #1173333 #

Total comments: 1

Patch Set 4 : Add failing provider notice and fix #1173333 #

Total comments: 7

Patch Set 5 : Add failing provider notice and fix #1173333 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+623 lines, -449 lines) Patch
A [revision details] View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
D app/assets/images/provider_icons/provider-aws.svg View 1 chunk +0 lines, -148 lines 0 comments Download
A app/assets/images/provider_icons/provider-ec2.svg View 1 chunk +148 lines, -0 lines 0 comments Download
A app/assets/images/provider_icons/provider-local.svg View 1 chunk +99 lines, -0 lines 0 comments Download
D app/assets/images/provider_icons/provider-lxc01.svg View 1 chunk +0 lines, -99 lines 0 comments Download
M app/models/charm.js View 1 chunk +29 lines, -0 lines 0 comments Download
M app/subapps/browser/browser.js View 1 chunk +11 lines, -0 lines 0 comments Download
M app/subapps/browser/templates/browser_charm.handlebars View 1 2 3 4 chunks +21 lines, -10 lines 0 comments Download
M app/subapps/browser/views/charm.js View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M app/subapps/browser/views/editorial.js View 2 chunks +14 lines, -1 line 0 comments Download
M app/subapps/browser/views/search.js View 2 chunks +21 lines, -1 line 0 comments Download
M lib/views/browser/charm-full.less View 1 2 3 2 chunks +18 lines, -0 lines 0 comments Download
M test/data/browsercharm.json View 1 chunk +189 lines, -189 lines 0 comments Download
M test/test_browser_charm_details.js View 1 chunk +17 lines, -0 lines 0 comments Download
M test/test_browser_editorial.js View 1 2 3 1 chunk +44 lines, -0 lines 0 comments Download
M test/test_model.js View 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 10
rharding
Please take a look.
9 years, 7 months ago (2013-04-27 01:39:50 UTC) #1
rharding
Please take a look.
9 years, 7 months ago (2013-04-27 13:31:17 UTC) #2
rharding
Please take a look.
9 years, 7 months ago (2013-04-27 13:48:55 UTC) #3
gary.poster
code looks good. will qa later today. https://codereview.appspot.com/8651046/diff/6001/test/test_browser_editorial.js File test/test_browser_editorial.js (right): https://codereview.appspot.com/8651046/diff/6001/test/test_browser_editorial.js#newcode164 test/test_browser_editorial.js:164: it('unsetting the ...
9 years, 7 months ago (2013-04-27 17:06:02 UTC) #4
rharding
Please take a look.
9 years, 7 months ago (2013-04-29 10:42:22 UTC) #5
rharding
Originally the mysql and cinder charms were failing on ec2 and usable for QA. On ...
9 years, 7 months ago (2013-04-29 10:51:26 UTC) #6
j.c.sackett
https://codereview.appspot.com/8651046/diff/1017/app/models/charm.js File app/models/charm.js (right): https://codereview.appspot.com/8651046/diff/1017/app/models/charm.js#newcode415 app/models/charm.js:415: failing.push('hp'); Does this mean that HP cannot independently fail? ...
9 years, 7 months ago (2013-04-29 15:06:21 UTC) #7
rharding
Feedback below. https://codereview.appspot.com/8651046/diff/1017/app/models/charm.js File app/models/charm.js (right): https://codereview.appspot.com/8651046/diff/1017/app/models/charm.js#newcode415 app/models/charm.js:415: failing.push('hp'); On 2013/04/29 15:06:22, j.c.sackett wrote: > ...
9 years, 7 months ago (2013-04-29 15:09:51 UTC) #8
j.c.sackett
Thanks for responses; LGTM. https://codereview.appspot.com/8651046/diff/1017/app/subapps/browser/views/editorial.js File app/subapps/browser/views/editorial.js (right): https://codereview.appspot.com/8651046/diff/1017/app/subapps/browser/views/editorial.js#newcode113 app/subapps/browser/views/editorial.js:113: // Watch for changse to ...
9 years, 7 months ago (2013-04-29 15:12:58 UTC) #9
rharding
9 years, 7 months ago (2013-04-29 19:34:02 UTC) #10
*** Submitted:

Add failing provider notice and fix #1173333

- When a provider is known to be failing add a warning container and show the
provider icon. 
- Drive by fix for #1173333 to make sure that we can 'deactive' a selected
charm in the editorial and search views.

R=gary.poster, j.c.sackett
CC=
https://codereview.appspot.com/8651046
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b