Issue 8648046: Fix login screen not displayed.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 8648046: Fix login screen not displayed.

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 5 months ago by frankban

Modified:
11 years, 5 months ago

Reviewers:
mp+159804, gary.poster

Visibility:
Public.

Description

Fix login screen not displayed. This regression was introduced in revision 573. That was a fix for bug 1170062: scrollbar visible when searching for charm in browser panel. I have no idea of the reason, but a CSS overflow hidden directive was hiding the login panel. Fixed moving that directive in an inner element. This way it seems the regression is fixed also preserving the previous scrollbar fix. https://code.launchpad.net/~frankban/juju-gui/manic-regression/+merge/159804 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Fix login screen not displayed. #

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -2 lines)			Patch
	A	[revision details]	View		1 chunk	+2 lines, -0 lines	0 comments	Download
	M	lib/views/stylesheet.less	View		1 chunk	+1 line, -2 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

frankban

11 years, 5 months ago (2013-04-19 13:00:41 UTC) #3

*** Submitted:

Fix login screen not displayed.

This regression was introduced in revision 573.
That was a fix for bug 1170062: scrollbar visible 
when searching for charm in browser panel.

I have no idea of the reason, but a CSS overflow hidden
directive was hiding the login panel. Fixed moving that 
directive in an inner element. This way it seems the 
regression is fixed also preserving the previous 
scrollbar fix.

R=gary.poster
CC=
https://codereview.appspot.com/8648046

Expand All Messages | Collapse All Messages