Issue 8648045: cmd/juju: don't panic if machine missing

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 8648045: cmd/juju: don't panic if machine missing (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years ago by dave

Modified:
10 years, 12 months ago

Reviewers:
mp+159558

Visibility:
Public.

Description

cmd/juju: don't panic if machine missing * Properly handle the case where the provider provided instance id is not present. * fix json and yaml formatting to hide a blank instance-id if the instance is missing. * added tests for instance-id: "pending" and instance-state: "missing" https://code.launchpad.net/~dave-cheney/juju-core/117-fix-juju-status-panic/+merge/159558 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : cmd/juju: don't panic if machine missing #

Created: 11 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+43 lines, -1 line)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	cmd/juju/status.go	View	2 chunks	+2 lines, -1 line	0 comments	Download
M	cmd/juju/status_test.go	View	2 chunks	+39 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

dave_cheney.net

11 years ago (2013-04-18 08:22:54 UTC) #4

*** Submitted:

cmd/juju: don't panic if machine missing

* Properly handle the case where the provider provided instance id is not
present.
* fix json and yaml formatting to hide a blank instance-id if the instance is
missing.
* added tests for instance-id: "pending" and instance-state: "missing"

R=TheMue, fwereade
CC=
https://codereview.appspot.com/8648045

Expand All Messages | Collapse All Messages