Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1547)

Issue 8648045: cmd/juju: don't panic if machine missing (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 7 months ago by dfc
Modified:
9 years, 7 months ago
Reviewers:
mp+159558
Visibility:
Public.

Description

cmd/juju: don't panic if machine missing * Properly handle the case where the provider provided instance id is not present. * fix json and yaml formatting to hide a blank instance-id if the instance is missing. * added tests for instance-id: "pending" and instance-state: "missing" https://code.launchpad.net/~dave-cheney/juju-core/117-fix-juju-status-panic/+merge/159558 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : cmd/juju: don't panic if machine missing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -1 line) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M cmd/juju/status.go View 2 chunks +2 lines, -1 line 0 comments Download
M cmd/juju/status_test.go View 2 chunks +39 lines, -0 lines 0 comments Download

Messages

Total messages: 4
dfc
Please take a look.
9 years, 7 months ago (2013-04-18 06:28:35 UTC) #1
TheMue
LGTM, good catch.
9 years, 7 months ago (2013-04-18 06:54:43 UTC) #2
fwereade
LGTM
9 years, 7 months ago (2013-04-18 08:05:18 UTC) #3
dfc
9 years, 7 months ago (2013-04-18 08:22:54 UTC) #4
*** Submitted:

cmd/juju: don't panic if machine missing

* Properly handle the case where the provider provided instance id is not
present.
* fix json and yaml formatting to hide a blank instance-id if the instance is
missing.
* added tests for instance-id: "pending" and instance-state: "missing"

R=TheMue, fwereade
CC=
https://codereview.appspot.com/8648045
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b