Patch for FS#2457 - Cannot add item to container even if guard is far away.

Rizin (and others) sometimes had problems adding items to furnaces, chest, etc. The error they saw was most likely because the container was guarded. I found that in CanAdd, it did not check if the guarding character was nearby (as it does in the function CanTake). I added a check for that, and tested.

link to bug report:
http://www.hydlaa.com/flyspray_upgrade/index.php?do=details&task_id=2457

[Kayden, 2008-11-11 19:12:59]

Looks good, but I'm unsure about the logic.  (See comments near the source in
question.)

http://codereview.appspot.com/8647/diff/1/2
File src/server/gem.cpp (right):

http://codereview.appspot.com/8647/diff/1/2#newcode3929
Line 3929: && (!guardingActor || (guardingActor->RangeTo(this) <= 5)))
This logic seems wrong to me.  If the character is logged out (!guardingActor),
then the last condition will be true, causing it to disallow the add.

I think it should be:

if (guard.IsValid() && guard != item->GetOwningCharacterID() && guardingActor &&
guardingActor->RangeTo(this) <= 5)
    return false;

Namely, disallow adding if (1) there's a guard, (2) it's not you, (3) they're
logged on, and (4) they're nearby.

This gives what I believe to be the desired semantics:
1. Players can add items to containers they guard.
2. All others can add only when (a) the guard is logged out, or (b) the guard is
far away.

[Lanarel, 2008-11-11 19:47:12]

Updated patch for FS#2457  - Cannot add item to container even if guard is far
away

[Lanarel, 2008-11-11 19:48:07]

Updated patch for FS#2457  - Cannot add item to container even if guard is far
away

[Lanarel, 2008-11-11 19:50:56]

Tried to upload a new patch 4 times (sorry if you did get emails :) ) but it
does not appear.
Anyway, you were right. When inverting the test I copied from CanTake, I made a
mistake. Your version corresponds to 
!(!guardingActor || (guardingActor->RangeTo(this) > 5)), which it should be :)
I tested again, this time with guarding chars logging off, and it works as it
should (and as you describe).

[Lanarel, 2008-11-11 19:55:02]

/me makes note that codereview needs to refresh page before a new patch is
visible.

[Kayden, 2008-11-12 07:52:26]

Thanks, looks good. :) Committed in trunk r2418.