Prospect patch FS#698 - Control the angle of items you drop.

Patch by Kougaro to create a rotate command.
Previous version have been tested, now some small changes are made (incremental rotation, rotating over single axis, reset, players only in guildhouses). THese changes not tested (because of local mess with patched files). Uploading now so it can be reviewed. 

I hope the patch works (it is a dos2unixed version of the paste site).

Feature request: http://www.hydlaa.com/flyspray_upgrade/index.php?do=details&task_id=698

[Lanarel, 2008-11-11 13:47:26]

Ok, so patch does not work. I will make a new one from clean trunk in a bit.

[Lanarel, 2008-11-11 14:39:52]

Some comments. Only me nitpicking :)

http://codereview.appspot.com/8645/diff/23/221
File data/help.xml (right):

http://codereview.appspot.com/8645/diff/23/221#newcode168
Line 168: <topic name="/rotate">/rotate target x y z
Should also explain /rotate x reset and /rotate reset

http://codereview.appspot.com/8645/diff/23/209
File src/server/adminmanager.cpp (right):

http://codereview.appspot.com/8645/diff/23/209#newcode444
Line 444: y = (words[3] == "reset")?0:words.GetFloat(3);
words[3] is never "reset" here, so this should just be words.GetFloat(3);

http://codereview.appspot.com/8645/diff/23/209#newcode457
Line 457: z = (words[3] == "reset")?0:words.GetFloat(3);
again, just words.GetFloat(3)

http://codereview.appspot.com/8645/diff/23/209#newcode3888
Line 3888: if ( (target->GetSector()->QueryObject()->GetName() != "guildlaw") &&
!extras )
I don't like hardcoded planeshift things :). Better would be only allow rotating
outside of instance 0 maybe?

http://codereview.appspot.com/8645/diff/23/209#newcode3904
Line 3904: if (data.xreset || data.treset)
why use treset and not just set xreset=yreset=zreset=0 when parsing the command?

http://codereview.appspot.com/8645/diff/23/214
File src/server/bulkobjects/psitem.cpp (right):

http://codereview.appspot.com/8645/diff/23/214#newcode510
Line 510: updateQuery = db->NewUpdatePreparedStatement("item_instances", "id",
27, __FILE__, __LINE__); // 27 fields + 1 id field
comment should be 26+1? :)

http://codereview.appspot.com/8645/diff/23/212
File src/server/database/mysql/upgrade_schema.sql (right):

http://codereview.appspot.com/8645/diff/23/212#newcode1044
Line 1044: #### 1205 - Tristan "kougaro" Cragnolini - Add a /rotate command. To
rotate things, duh.
since this now is a diff from a newer version, 1205 should be 1206

http://codereview.appspot.com/8645/diff/23/204
File src/server/gem.cpp (right):

http://codereview.appspot.com/8645/diff/23/204#newcode839
Line 839: UpdateProxList(true);
how does the proxlist change when the char is only rotated? is this call needed?

http://codereview.appspot.com/8645/diff/23/204#newcode1161
Line 1161: //    csMatrix3 xtransf =
GetMeshWrapper()->GetMovable()->GetTransform().GetT2O();
comments can go?

http://codereview.appspot.com/8645/diff/23/204#newcode1492
Line 1492: void gemItem::SetRotation(float xangle, float yangle, float zangle)
why different naming here than in GetRotation? (and declaration in gem.h)

[kougaro, 2008-11-11 21:35:12]

Just two things :
for the hardcoded thing, even with a check to instance=0, it will be hardcoded,
for now we need something hardcoded.
for the different namings, I think i did mainly so I don't get too confused.

[Lanarel, 2008-11-11 21:42:18]

On 2008/11/11 21:35:12, kougaro wrote:
> Just two things :
> for the hardcoded thing, even with a check to instance=0, it will be
hardcoded,
> for now we need something hardcoded.
I like 'not instance 0' better than using a map name that is planeshift
specific, and will no longer work when there are different guildhouse maps, and
introduce a bug then ("why does it not work in my house!!")

> for the different namings, I think i did mainly so I don't get too confused.
The declaration in the headerfile uses xrot, it is just the function itself that
differs :)