code review 8638043: fmt: tweak the explanation of Stringer to be more corre...

fmt: tweak the explanation of Stringer to be more correct and less specific
The String method is called whenever the printing operation wants a string,
not just for %s and %v.

[r, 2013-04-10 20:44:35]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go/

[bradfitz, 2013-04-10 20:57:44]

LGTM



On Wed, Apr 10, 2013 at 1:44 PM, <r@golang.org> wrote:

> Reviewers: golang-dev1,
>
> Message:
> Hello golang-dev@googlegroups.com,
>
> I'd like you to review this change to
> https://code.google.com/p/go/
>
>
> Description:
> fmt: tweak the explanation of Stringer to be more correct and less
> specific
> The String method is called whenever the printing operation wants a
> string,
> not just for %s and %v.
>
> Please review this at
https://codereview.appspot.**com/8638043/<https://codereview.appspot.com/8638...
>
> Affected files:
>   src/pkg/fmt/print.go
>
>
> Index: src/pkg/fmt/print.go
> ==============================**==============================**=======
> --- a/src/pkg/fmt/print.go
> +++ b/src/pkg/fmt/print.go
> @@ -56,7 +56,8 @@
>  // Stringer is implemented by any value that has a String method,
>  // which defines the ``native'' format for that value.
>  // The String method is used to print values passed as an operand
> -// to a %s or %v format or to an unformatted printer such as Print.
> +// to any format that accepts a string or to an unformatted printer
> +// such as Print.
>  type Stringer interface {
>         String() string
>  }
>
>
> --
>
> ---You received this message because you are subscribed to the Google
> Groups "golang-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to
golang-dev+unsubscribe@**googlegroups.com<golang-dev%2Bunsubscribe@googlegrou...
> .
> For more options, visit
https://groups.google.com/**groups/opt_out<https://groups.google.com/groups/o...
> .
>
>
>

[r, 2013-04-10 21:05:37]

*** Submitted as https://code.google.com/p/go/source/detail?r=522c34c6fe61 ***

fmt: tweak the explanation of Stringer to be more correct and less specific
The String method is called whenever the printing operation wants a string,
not just for %s and %v.

R=golang-dev, bradfitz
CC=golang-dev
https://codereview.appspot.com/8638043

[u, 2013-04-13 03:31:07]

Clarification of the Formatter comment required.

https://codereview.appspot.com/8638043/diff/3002/src/pkg/fmt/print.go
File src/pkg/fmt/print.go (right):

https://codereview.appspot.com/8638043/diff/3002/src/pkg/fmt/print.go#newcode50
src/pkg/fmt/print.go:50: // The implementation of Format may call Sprint(f) or
Fprint(f) etc.
In this case does f represent the a Formatter or a State? Sprint accepts a
Formatter as the first argument while Fprint accepts a State.

Example:
http://play.golang.org/p/hrStktWIcq

prog.go:14: cannot use f (type F) as type io.Writer in function argument:
	F does not implement io.Writer (missing Write method)

[r, 2013-04-13 05:32:43]

It's shorthand for Sprint or Sprintf, etc.

-rob